1102427 - Ensure scroll parents of an active scrollframe are layerized

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

This is a spinoff from bug 918288.

In that bug I had a patch that ensured that scrollframes that were in the ancestor chain of a scrollframe with a displayport also got layerized. This is needed for scroll handoff to work properly in some cases in a world where we have no scrollinfo layers (or scrollinfo layers are ignored on the APZ side, which is what happens when the layout.event-regions.enabled pref is turned on).

As tn pointed out, the patch on that bug depends on having containerless scrolling working first, so I'm splitting it into a separate bug so as to not hold up the rest of the patches.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Parking this patch here for now; will come back to this once bug containerless scrolling stuff lands.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: rebased

Stealing w/ permission. This is kats' patch rebased to tip.

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8566766 [details] [diff] [review]
rebased

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #0)
> As tn pointed out, the patch on that bug depends on having containerless
> scrolling working first, so I'm splitting it into a separate bug so as to
> not hold up the rest of the patches.

Containerless scrolling doesn't seem to be turned on everywhere yet, so this can't land? So we either need to turn on containerless everywhere, or make this patch conditional on that pref, or make this patch work for the containerful case too.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

w/ containerless scrolling pref (in both places where it matters, though in theory only either is needed)

Comment 5

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8568258 [details] [diff] [review]
patch

Thanks.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a211d588d18d

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a211d588d18d