1102594 - Replace Firefox browser screenshots showing search box

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Kohei Yoshino [:kohei]]

/firefox/new/ has browser screenshots like
https://www.mozilla.org/media/img/firefox/new/browser.png
https://www.mozilla.org/media/img/firefox/new/browser-mac.png

As the en-US locale's default search engine will be Yahoo!, these images have to be replaced. How about just removing the Google icon, instead of using different images based on locales?

Comment 1

[Kohei Yoshino [:kohei]]

Attachment: browser.png w/o Google icon

Comment 2

[Mike Alexis [:malexis]]

(In reply to Kohei Yoshino [:kohei] from comment #0)
>How about just removing the Google icon, instead of using different images based on locales?

Jen, what do you think? ^^

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: pull request

Looks like the search engine icon has been replaced with the glass icon. There is no more G/Y/something logo on the search bar. Here's a PR to replace those images.

Comment 4

[Jennifer Bertsch [:jbertsch]]

This looks good to me.  Thanks for working on this one, Kohei!

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/042012bacb8b5aa5a26b7cfc49452a45060391f0
Fix Bug 1102594 - Replace Firefox landing page browser screenshots showing search box

https://github.com/mozilla/bedrock/commit/838474e5b2fd64bc3ce29781b1ff18afcdc39680
Merge pull request #2563 from kyoshino/bug-1102594-landing-screenshots

Fix Bug 1102594 - Replace Firefox landing page browser screenshots showing search box

Comment 6

[Paul [:pmac] McLanahan]

We missed that some cache busting is required for these new images to actually show in production. :agibson will follow up with a PR later today.

Comment 7

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Follow up cache-buster PR for the new images

Comment 8

[Kohei Yoshino [:kohei]]

Yup, the cache busting was in my PR but looks like I have overridden it with an old commit after restoring my MacBook Pro data from Time Machine. Sorry!

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/2c5018758413516a83cc4d28a1374b62d98e45aa
[fix bug 1102594] Cache bust browser screenshots on firefox new download page

https://github.com/mozilla/bedrock/commit/c629948a0a6a85881042ae36708e56002ab03763
Merge pull request #2580 from alexgibson/bug-1102594-cache-bust-browser-screenshots-firefox-new

[fix bug 1102594] Cache bust browser screenshots on firefox new download page

Comment 10

[Ben (:bensternthal)]

Found one more to include in this if possible: 

https://www.mozilla.org/en-US/firefox/developer/

We may need to contact someone on the deb browser team to re-create, there is a lot going on in the screenshot.

Comment 11

[Kohei Yoshino [:kohei]]

My pull request has unintentionally been reverted to an old commit, so the magnifier icon is still old one. I'll send another PR to update the image again. I can photoshop the Developer Edition screenshot too.

Comment 12

[Kohei Yoshino [:kohei]]

Attachment: pull request, take 2

Comment 13

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/8bf6f2af070e00db6a1e7972808379338270ada3
Fix Bug 1102594 - Replace Firefox browser screenshots showing search box

https://github.com/mozilla/bedrock/commit/18d9bde81d7a0c6f4c07bd75030f78bbb1a1be6e
Merge pull request #2581 from kyoshino/bug-1102594-screenshots

Fix Bug 1102594 - Replace Firefox browser screenshots showing search box