1102679 - Implement ignoreBOM for TextDecoder

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Spun off from bug 1092737.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Henri, how hard would this be to do?

Comment 2

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #1)
> Henri, how hard would this be to do?

Should be extremely easy if I understood the spec correctly.

(My understanding is: Our current behavior of always dropping the BOM should become the behavior that takes place is ignoreBOM is true and when ignoreBOM is false, we shouldn't remove the BOM. To not remove the BOM, we should instantiate the mozilla::Decoder using the WithoutBOMHandling variant of the factory methods instead of the WithBOMRemoval factory method right about here: https://searchfox.org/mozilla-central/source/dom/encoding/TextDecoder.cpp#45 )

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Pass around the TextDecoderOptions as needed, not just one boolean from it

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Implement support for the ignoreBOM option for TextDecoder

When ignoreBOM is true, the encoding spec says to not treat leading DOM bytes
specially, which corresponds to our NewDecoderWithoutBOMHandling factory method
for the encoder.

Comment 5

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Comment on attachment 8998011 [details] [diff] [review]
part 2.  Implement support for the ignoreBOM option for TextDecoder

Review of attachment 8998011 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bf52b9a4c93
part 1.  Pass around the TextDecoderOptions as needed, not just one boolean from it.  r=hsivonen
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b78b0c012ad
part 2.  Implement support for the ignoreBOM option for TextDecoder.  r=hsivonen

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/686d11ab65e4
followup.  Restore failure annotation that should not have been removed.  r=bzbarsky

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6bf52b9a4c93
https://hg.mozilla.org/mozilla-central/rev/4b78b0c012ad
https://hg.mozilla.org/mozilla-central/rev/686d11ab65e4