110276 - SQL error in globals.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P1)

Description

[Mike Schiraldi]

If you click on "Show dependency graph" for any bug, check "Show the summary of
all bugs" on the new page, and click Submit again, you get:

Software error:
select bug_status, short_desc from bugs LEFT JOIN cc selectVisible_cc ON
bugs.bug_id = selectVisible_cc.bug_id AND selectVisible_cc.who = 29933 WHERE
((bugs.groupset & 0) = bugs.groupset OR (bugs.reporter_accessible = 1 AND
bugs.reporter = 29933) OR (bugs.assignee_accessible = 1 AND bugs.assigned_to =
29933) OR (bugs.qacontact_accessible = 1 AND bugs.qa_contact = 29933) OR
(bugs.cclist_accessible = 1 AND selectVisible_cc.who = 29933 AND not
isnull(selectVisible_cc.who))) AND bug_id = 102293: Column: 'bug_id' in where
clause is ambiguous at globals.pl line 222.

Comment 1

[Jacob Steenhagen]

I believe SelectVisible() is doing this to us, as it now pulls in additional
tables that have bug_id in them.

The solution appears to be to s/AND bug_id/AND bugs.bug_id/ towards the end of
the SQL statement (that the only place I see an unqualified bug_id).

-> Bugzilla product

Comment 2

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 3

[Dave Miller [:justdave]]

This slipped through on the mass-update because it didn't have a priority set on
it.  Since this is a regression from 2.14 behavior, that makes it a release blocker.

Comment 4

[Matthew Tuck [:CodeMachine]]

Attachment: Easily fixed.

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 58345 [details] [diff] [review]
Easily fixed.

r=bbaetz

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 58345 [details] [diff] [review]
Easily fixed.

r=caillon

Comment 7

[Matthew Tuck [:CodeMachine]]

Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <-- 
showdependencygraph.cgi
new revision: 1.12; previous revision: 1.11
done