Closed
Bug 1102806
Opened 10 years ago
Closed 10 years ago
Blocking contacts doesn't work in Nightly and Aurora. Beta (Fx34) is fine.
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox34 unaffected, firefox35+ verified, firefox36+ verified)
People
(Reporter: mreavy, Assigned: mikedeboer)
References
Details
(Keywords: regression)
Attachments
(1 file)
3.84 KB,
patch
|
standard8
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
A blocked contact can still call me in Nightly (Fx36) and Aurora (Fx35). I was doing direct calls. I haven't tried rooms or link clicking (since Aurora doesn't have the pref flip for Rooms yet).
Reporter | ||
Updated•10 years ago
|
Severity: normal → critical
backlog: --- → Fx35+
Priority: -- → P1
Reporter | ||
Updated•10 years ago
|
Keywords: regression
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Iteration: --- → 36.3
Points: --- → 1
Flags: qe-verify-
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
OS: Windows 7 → All
Hardware: x86_64 → All
Assignee | ||
Comment 1•10 years ago
|
||
Well, this is embarrassing. This should be more of an rs than anything else, Mark.
Attachment #8526670 -
Flags: review?(standard8)
Comment 2•10 years ago
|
||
Comment on attachment 8526670 [details] [diff] [review] Patch v1: LoopCalls.jsm introduction forgot to include contacts blocking logic Review of attachment 8526670 [details] [diff] [review]: ----------------------------------------------------------------- This must get a test asap. We've already lost the functionality once, so we shouldn't loose it again. However, r=Standard8 for getting the regression fixed and landed as this is an important one. Also I noticed in testing this, that if I'm receiving a direct call, and choose "Cancel and Block", then the block doesn't happen. Please can you file a bug to get that fixed. Thanks.
Attachment #8526670 -
Flags: review?(standard8) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/31c6ec335e80
[Tracking Requested - why for this release]: Nominated to track since this is a regression.
status-firefox34:
--- → unaffected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox35:
--- → ?
tracking-firefox36:
--- → ?
Flags: qe-verify- → qe-verify+
https://hg.mozilla.org/mozilla-central/rev/31c6ec335e80
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Flags: in-moztrap+
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8526670 [details] [diff] [review] Patch v1: LoopCalls.jsm introduction forgot to include contacts blocking logic Approval Request Comment [Feature/regressing bug #]: Bug 1074663 [User impact if declined]: A user will still be contacted by blocked contacts, which is counter intuitive [Describe test coverage new/current, TBPL]: landed on m-c [Risks and why]: minor [String/UUID change made/needed]: n/a.
Attachment #8526670 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8526670 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•9 years ago
|
||
Verified fixed 36.0a2 (2014-12-17), 35b4 Win 7
You need to log in
before you can comment on or make changes to this bug.
Description
•