1102818 - 'Starting on' field has to be initialized with the current date

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marina Rodríguez [:mai]]

When the user changes the plan setup, the field Starting on must be initialized to the current date.
E.g.
   Today date is Friday, November 21, 2014
   If the user select Monthly plan, the value of 'Starting on' field must be '21'
   If the user select Weekly plan, the value of 'Starting on' field must be 'Friday'

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva,
would you mind reviewing the patch?
Regards

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8526721 [details] [review]
patch v1.0

Marina, can you point me to the specification talking about this and then ask for my review again?

Comment 3

[Marina Rodríguez [:mai]]

Hi Salva,
It was specified on the document - "Smart Data Consumption Draft v3 [Nov 11, 2014 ]", although this behaviour is commented on the customized plan. Juwei by IRC confirms me that behaviour is for all the plans. 
Regards

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8526721 [details] [review]
patch v1.0

LGTM. A couple of nits on GitHub. Thank you!

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8526721 [details] [review]
patch v1.0

Oh. I did not see a test for this. Please, add one. If you need to expose the function, do it. Maybe we can end with something like datautils.js with this kind of useful functions.

Do whatever you think is better. We have the change now.

Comment 6

[Marina Rodríguez [:mai]]

Comment on attachment 8526721 [details] [review]
patch v1.0

Added test.
Regards

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 8526721 [details] [review]
patch v1.0

Marina, please, split the test into two separated bugs, each testing one configuration and change the name for the test. Wait for Treeherder to be Green and merge. Thank you.

Comment 8

[Marina Rodríguez [:mai]]

Master: a5edd48f74bfa9b4b140a7b285404dcb575125d5