'Starting on' field has to be initialized with the current date

RESOLVED FIXED in 2.2 S1 (5dec)

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mai, Assigned: mai)

Tracking

unspecified
2.2 S1 (5dec)
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
salva
: review+
Details | Review
Assignee

Description

5 years ago
When the user changes the plan setup, the field Starting on must be initialized to the current date.
E.g.
   Today date is Friday, November 21, 2014
   If the user select Monthly plan, the value of 'Starting on' field must be '21'
   If the user select Weekly plan, the value of 'Starting on' field must be 'Friday'
Assignee

Updated

5 years ago
Blocks: 1089955
No longer depends on: 1089955
Assignee

Comment 1

5 years ago
Posted file patch v1.0
Hi Salva,
would you mind reviewing the patch?
Regards
Attachment #8526721 - Flags: review?(salva)
Comment on attachment 8526721 [details] [review]
patch v1.0

Marina, can you point me to the specification talking about this and then ask for my review again?
Attachment #8526721 - Flags: review?(salva)
Assignee

Comment 3

5 years ago
Hi Salva,
It was specified on the document - "Smart Data Consumption Draft v3 [Nov 11, 2014 ]", although this behaviour is commented on the customized plan. Juwei by IRC confirms me that behaviour is for all the plans. 
Regards
Assignee

Updated

5 years ago
Attachment #8526721 - Flags: review?(salva)
Comment on attachment 8526721 [details] [review]
patch v1.0

LGTM. A couple of nits on GitHub. Thank you!
Attachment #8526721 - Flags: review?(salva) → review+
Comment on attachment 8526721 [details] [review]
patch v1.0

Oh. I did not see a test for this. Please, add one. If you need to expose the function, do it. Maybe we can end with something like datautils.js with this kind of useful functions.

Do whatever you think is better. We have the change now.
Assignee

Comment 6

5 years ago
Comment on attachment 8526721 [details] [review]
patch v1.0

Added test.
Regards
Attachment #8526721 - Flags: review+ → review?(salva)
Comment on attachment 8526721 [details] [review]
patch v1.0

Marina, please, split the test into two separated bugs, each testing one configuration and change the name for the test. Wait for Treeherder to be Green and merge. Thank you.
Attachment #8526721 - Flags: review?(salva) → review+
Assignee

Comment 8

5 years ago
Master: a5edd48f74bfa9b4b140a7b285404dcb575125d5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
User Story: (updated)
Whiteboard: [ucid:SMRTDATA-13-11][NaBfT]
Target Milestone: --- → 2.2 S1 (5dec)
Assignee: nobody → marina.rodriguez.iglesias
You need to log in before you can comment on or make changes to this bug.