Windows 8 x64 PGO builds fail when trying to update the Chromium sandbox code to commit 9522fad406dd161400daa518075828e47bd47f60

RESOLVED FIXED in Firefox 52

Status

()

Core
Security: Process Sandboxing
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: bobowen, Assigned: bobowen)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: sbwc2)

User Story

This is just to keep track of the fact that we've had to disable PGO in some way for the Chromium sandbox code on Windows x64 builds.

We should see if we can re-enable this when we update to a newer Chromium commit.

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
See user story.
Move process sandboxing bugs to their new, separate component.

(Sorry for the bugspam; filter on 3c21328c-8cfb-4819-9d88-f6e965067350.)
Component: Security → Security: Process Sandboxing

Updated

2 years ago
Whiteboard: sbwc2
Depends on: 1186060
(Assignee)

Updated

2 years ago
Flags: needinfo?(bobowen.code)
(Assignee)

Comment 2

2 years ago
Created attachment 8797400 [details] [diff] [review]
Remove PGO exception for sharedmem_ipc_client.cc

This problem with PGO builds appears to have gone now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ab49f568aca4f2a6a4b36d9f4558eb7151ad8f0

MozReview-Commit-ID: Qx44MNtns8
Attachment #8797400 - Flags: review?(mh+mozilla)
(Assignee)

Updated

2 years ago
Assignee: nobody → bobowen.code
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Flags: needinfo?(bobowen.code)
Attachment #8797400 - Flags: review?(mh+mozilla) → review+

Comment 3

2 years ago
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cad4dafdc225
Remove PGO exception for sharedmem_ipc_client.cc. r=glandium

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cad4dafdc225
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.