Closed
Bug 1102855
Opened 10 years ago
Closed 9 years ago
Use of uninitialised variable in nsWindow.cpp
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(1 file)
781 bytes,
patch
|
jimm
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. Start thunderbird.exe -silent -jsconsole * 2. Evaluate fullScreen = true 3. Evaluate fullScreen = false Expected result: Window chrome is restored Actual result: Window chrome is still hidden * Sorry, but Firefox's Browser Console sucks for demonstrating this.
Assignee | ||
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Attachment #8526725 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8526725 [details] [diff] [review] Proposed patch Approval Request Comment [Feature/regressing bug #]: 1063121 [User impact if declined]: Full screen might not work reliably [Risks and why]: No risk [String/UUID change made/needed]: None
Attachment #8526725 -
Flags: approval-mozilla-beta?
Attachment #8526725 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/285c55e9b40d
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/285c55e9b40d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment 5•9 years ago
|
||
Looks like this is a regression 34. It's too late in the cycle for anything other than a stop ship bug. Can we live with this in the 34 cycle?
Flags: needinfo?(neil)
Comment 6•9 years ago
|
||
Comment on attachment 8526725 [details] [diff] [review] Proposed patch I spoke with jimm and gavin on irc. Both think we need to take this. Low risk and can still make it in time for RC. Beta+ Aurora+
Attachment #8526725 -
Flags: approval-mozilla-beta?
Attachment #8526725 -
Flags: approval-mozilla-beta+
Attachment #8526725 -
Flags: approval-mozilla-aurora?
Attachment #8526725 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Flags: needinfo?(neil)
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/1e56eee0d3e1 https://hg.mozilla.org/releases/mozilla-beta/rev/c3962be01621 https://hg.mozilla.org/releases/mozilla-release/rev/c3962be01621
You need to log in
before you can comment on or make changes to this bug.
Description
•