Closed
Bug 1102985
Opened 10 years ago
Closed 9 years ago
sdb.c:1694:19: warning: unused variable 'ALTER_CMD' [-Wunused-const-variable]
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.17.4
People
(Reporter: dholbert, Assigned: Cykesiopka)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
825 bytes,
patch
|
elio.maldonado.batiz
:
review+
|
Details | Diff | Splinter Review |
Build warning, with clang 3.5:
{
sdb.c:1694:19: warning: unused variable 'ALTER_CMD' [-Wunused-const-variable]
static const char ALTER_CMD[] =
^
}
ALTER_CMD has been in this file since the file was created, in bug 217538, and it seems to have never been used. (It was unused in the changeset that added it: https://hg.mozilla.org/projects/nss/diff/464bdd3125a7/security/nss/lib/softoken/sdb.c ) Historical note: at that point it was a #define; it was upgraded to a static const char [] in bug 391291.
Anyway, we should just drop it, since it's unused.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Attachment #8530498 -
Flags: review?(emaldona)
|
||
Updated•10 years ago
|
Attachment #8530498 -
Flags: review?(emaldona) → review+
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/0455ebb9ad00
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(kaie)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.18
You need to log in
before you can comment on or make changes to this bug.
Description
•