1103173 - Get rid of the last open-codes Chunk list management

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: use_chunkpool_to_return_expired-v0.diff

There is only one spot left: expiration. Now that there is no prevp weirdness going on, we can safely make ChunkPool copyable and use one to return the chunks we want to expire.

These hunks have probably already been reviewed, but it's a trivial patch so...

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=efb94be3379d

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8527008 [details] [diff] [review]
use_chunkpool_to_return_expired-v0.diff

Review of attachment 8527008 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +3429,5 @@
>      rt->threadPool.pruneChunkCache();
>  #endif
>  
> +    ChunkPool toFree = expireEmptyChunkPool(shouldShrink, lock);
> +    {

You could save an unlock/lock if you checked for an empty pool like it did before. Might avoid a little bit of context switching.

Comment 2

[Terrence Cole [:terrence]]

Ah, I remember having this conversation before. Did I really fail to apply the feedback from the prior review? I guess I asked for re-review for a good reason!

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=efb94be3379d
https://hg.mozilla.org/integration/mozilla-inbound/rev/e33876e4431e

Comment 3

[Terrence Cole [:terrence]]

And because I apparently you can qfinish with unsaved changes:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f440594be934

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f440594be934