Closed
Bug 1103173
Opened 10 years ago
Closed 9 years ago
Get rid of the last open-codes Chunk list management
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
7.44 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
There is only one spot left: expiration. Now that there is no prevp weirdness going on, we can safely make ChunkPool copyable and use one to return the chunks we want to expire. These hunks have probably already been reviewed, but it's a trivial patch so... https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=efb94be3379d
Attachment #8527008 -
Flags: review?(sphink)
Comment 1•10 years ago
|
||
Comment on attachment 8527008 [details] [diff] [review] use_chunkpool_to_return_expired-v0.diff Review of attachment 8527008 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsgc.cpp @@ +3429,5 @@ > rt->threadPool.pruneChunkCache(); > #endif > > + ChunkPool toFree = expireEmptyChunkPool(shouldShrink, lock); > + { You could save an unlock/lock if you checked for an empty pool like it did before. Might avoid a little bit of context switching.
Attachment #8527008 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Ah, I remember having this conversation before. Did I really fail to apply the feedback from the prior review? I guess I asked for re-review for a good reason! https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=efb94be3379d https://hg.mozilla.org/integration/mozilla-inbound/rev/e33876e4431e
Assignee | ||
Comment 3•10 years ago
|
||
And because I apparently you can qfinish with unsaved changes: https://hg.mozilla.org/integration/mozilla-inbound/rev/f440594be934
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f440594be934
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•