Get rid of the last open-codes Chunk list management

RESOLVED FIXED in mozilla36

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

Trunk
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8527008 [details] [diff] [review]
use_chunkpool_to_return_expired-v0.diff

There is only one spot left: expiration. Now that there is no prevp weirdness going on, we can safely make ChunkPool copyable and use one to return the chunks we want to expire.

These hunks have probably already been reviewed, but it's a trivial patch so...

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=efb94be3379d
Attachment #8527008 - Flags: review?(sphink)
Comment on attachment 8527008 [details] [diff] [review]
use_chunkpool_to_return_expired-v0.diff

Review of attachment 8527008 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +3429,5 @@
>      rt->threadPool.pruneChunkCache();
>  #endif
>  
> +    ChunkPool toFree = expireEmptyChunkPool(shouldShrink, lock);
> +    {

You could save an unlock/lock if you checked for an empty pool like it did before. Might avoid a little bit of context switching.
Attachment #8527008 - Flags: review?(sphink) → review+
(Assignee)

Comment 2

3 years ago
Ah, I remember having this conversation before. Did I really fail to apply the feedback from the prior review? I guess I asked for re-review for a good reason!

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=efb94be3379d
https://hg.mozilla.org/integration/mozilla-inbound/rev/e33876e4431e
(Assignee)

Comment 3

3 years ago
And because I apparently you can qfinish with unsaved changes:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f440594be934
https://hg.mozilla.org/mozilla-central/rev/f440594be934
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.