110341 - mfcembed.exe missing from Embed folder

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Tracy Walker [:tracy]]

seen on this mornings embed builds for 2001-11-15-05-trunk & 2001-11-15-09-trunk

-install the embed build using the embed-win32.zip

The resulting "Embed" folder is missing the mfcembed.exe icon

Can't run the app!

Comment 1

[Adam Lock]

Nothing has changed in the embedding manifest or makefile that controls whether
mfcEmbed gets built or not. The only obvious thing that would prevent mfcEmbed
being built is setting the NO_MFC environment variable.

Was winEmbed built?

Comment 2

[hacker formerly known as [e-mail]]

Or by setting DISABLE_TESTS.  Did the win32 automation change?

Comment 3

[lpham]

We turnned off the tests on the build machine and it causes this problem.  Leaf 
is looking on it and will turn this one on.

Comment 4

[lpham]

Downgrade this bug to critical and reassign to leaf.

Comment 5

[Daniel (Leaf) Nunes]

Simple patch will fix, hopefully i can get an r=, sr= today

Index: makefile.win
===================================================================
RCS file: /cvsroot/mozilla/embedding/makefile.win,v
retrieving revision 1.4
diff -u -r1.4 makefile.win
--- makefile.win        2001/04/18 04:19:09     1.4
+++ makefile.win        2001/11/16 19:22:58
@@ -22,7 +22,7 @@
 DEPTH=..

 DIRS=base components browser
-!if !defined(DISABLE_TESTS)
+!if !defined(DISABLE_TESTS) || defined(MOZILLA_OFFICIAL)
 DIRS=$(DIRS) tests
 !endif

Comment 6

[hacker formerly known as [e-mail]]

r=cls

Comment 7

[Daniel (Leaf) Nunes]

patch committed.

Comment 8

[Tracy Walker [:tracy]]

verified with mfcembed build 2001-11-19-06-trunk