1103418 - Use Object.assign instead of copySharedBaseToPrototype

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Comment 1

[aleth [:aleth]]

Attachment: objectassign.diff

Comment 2

[Florian Quèze [:florian]]

Why?

Also, are you sure this really does the same thing?

Comment 3

[aleth [:aleth]]

(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> Why?

One less custom helper function needed?
 
> Also, are you sure this really does the same thing?

There is a polyfill on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign. There would be edge case differences if GenericIRCConversation didn't just have standard own properties.

Btw, I'm not wedded to this, but I thought a patch was a quick way to discuss it ;)

Comment 4

[Florian Quèze [:florian]]

Bah, ignore me, I'm tired. I looked at the patch quickly and thought you were removing some of the prototype hackery I did a long time ago in imThemes.jsm.

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8527235 [details] [diff] [review]
objectassign.diff

Review of attachment 8527235 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming you've tested this, that change looks  like a nice simplification.

Comment 6

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/287344335622