1103597 - ES6 CONST causes loadSubScript("chrome://messenger/content/pref-mailnews.js") failed: SyntaxError: const declaration not directly within block

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Philip Chee]

Sun Nov 23 2014 21:13:58
Error: prefpane.paneload: loadSubScript("chrome://messenger/content/pref-mailnews.js") failed:
SyntaxError: const declaration not directly within block
Source file: chrome://communicator/content/bindings/prefwindow.xml
Line: 523

See Bug 611388 - const should be block-scoped and an initializer should be required

Comment 1

[Philip Chee]

Attachment: Patch v1.0 fix use of CONST

> -if ("@mozilla.org/suite/shell-service;1" in Components.classes)
> -  const nsIShellService = Components.interfaces.nsIShellService;
> +const nsIShellService = "@mozilla.org/suite/shell-service;1" in Components.classes ?
> +                        Components.interfaces.nsIShellService : null;
...
> -  if ("@mozilla.org/suite/shell-service;1" in Components.classes) try {
> +  if (nsIShellService) try {

I wonder if I could just use:
const nsIShellService = Components.interfaces.nsIShellService;
and then rely on truthy/falsy:
if (nsIShellService) {....}

I'll open a separate bug to audit /suite/ for non ES6 compliant uses of CONST.

Comment 2

[[e-mail]]

Comment on attachment 8527309 [details] [diff] [review]
Patch v1.0 fix use of CONST

Not really want I want, sorry. Just change it to var for now.

Comment 3

[Philip Chee]

Attachment: Patch v2.0 just convert const to var

(In reply to [e-mail] from comment #2)
> Comment on attachment 8527309 [details] [diff] [review]
> Not really want I want, sorry. Just change it to var for now.
OK. Done.

Comment 4

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/43ceb691f62c