110372 - [mach] nav services dialogs don't display

Status: RESOLVED WORKSFORME

(Core Graveyard :: File Handling, defect)

Description

[cyrus]

The Download "save this file to disk" option doesn't do anything.

Comment 1

[Matthias Versen [:Matti]]

Reporter: Which build id ?

Comment 2

[cyrus]

fizzilla-mach built from last night's tree (no build id - it would be cool if 
there was a global sequence number associated with each cvs commit 
we could use to track the state of the last pull prior to build). Haven't tried 
this on FizillaCFM.

Comment 3

[sairuh (rarely reading bugmail)]

is this limited to fizz-mach? if yes, then qa contact should go to zach [till
verif bits become available for me to test]...

however, lemme know if this is also seen on the usual os x bits available...

Comment 4

[Mike Pinkerton (not reading bugmail)]

yeah, i don't think the nav services dialogs are getting created from the widget
code. can you download things that don't require a native file save dialog?

Comment 5

[cyrus]

how to test? d-n-d is busted, so I can't do that. "save page as" crashes. I 
suppose that should be a separate bug?

Comment 6

[Mike Pinkerton (not reading bugmail)]

try one of the download links off the mozilla.org homepage that starts a
download automatically. it should just start downloading and not prompt you for
a file location.

Comment 7

[cyrus]

the download links all (.gz, .zip, .bin) bring up the dialog box to "open with
app..." "save as". Save as is busted (this bug). Open with app doesn't work
because the button "choose" button doesn't do anything. Sounds like that's
another bug (or perhaps the some one since it's just bringing up a file dialog
only it's to find the app, rather than to set the location for saving).

Comment 8

[Mike Pinkerton (not reading bugmail)]

oh, you're right. duh.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I noticed that there are some key bits of code in
widget/src/mac/nsFilePicker.cpp that are |#ifndef XP_MACOSX| because there's no
nsILocalFileMac in the mach-o build.  The lack of an alternative codepath is
causing crashes.  Not sure about why things wouldn't display at all, though.

Comment 10

[Mike Pinkerton (not reading bugmail)]

*** Bug 113774 has been marked as a duplicate of this bug. ***

Comment 11

[Mike Pinkerton (not reading bugmail)]

other bug was a dupe, here's the original --> conrad.

Comment 12

[Conrad Carlen (not reading bugmail)]

This would be good to fix.

Comment 13

[Conrad Carlen (not reading bugmail)]

Because of comment #9, I say that the fix is to have a version of nsLocalFileMac
for mach-0. Also, when I tested this, I found that the dialog did display - it
just crashed right afterwards for the reason David gave. Closing this and filing
a new bug for the need for nsLocalFileMac on mach-0.

Comment 14

[Conrad Carlen (not reading bugmail)]

New one is bug 118203. Closing this as WFM since the dialog did display. If,
after we have an nsLocalFileMac impl and don't crash for that reason, this is
still a problem, re-open it.