1103809 - [Settings][Dialog] call_settings/voicemail should be shown as a dialog

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

As title, call_settings/voicemail should be shown as a dialog. We should use settings dialog to show it.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8539177 [details] [review]
patch on master

Arthur, based on our offline discussion, let's try to accomplish these patches first instead of refactoring the whole call settings because there would be high chances to cause regression.

Can you help me review this patch ? thanks !!

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8539177 [details] [review]
patch on master

Good work! There is a minor thing related to UX to be addressed before merging, please check github, thanks!

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8539177 [details] [review]
patch on master

Thanks Arthur, all comments are addressed ! please help me check again :)

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8539177 [details] [review]
patch on master

r=me, thanks.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, merged into Gaia/master:  https://github.com/mozilla-b2g/gaia/commit/69052349bbe670cd1b995548ff7c6946ec24a4cd