Closed
Bug 1103810
Opened 10 years ago
Closed 9 years ago
[Settings][Dialog] call_settings/call_forwarding should be shown as a dialog
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(tracking-b2g:+)
RESOLVED
FIXED
tracking-b2g | + |
People
(Reporter: eragonj, Assigned: eragonj)
References
Details
Attachments
(1 file)
As title, call_settings/call_forwarding should be shown as a dialog. We should use settings dialog to show it.
Updated•10 years ago
|
blocking-b2g: --- → backlog
tracking-b2g:
--- → +
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ejchen
Assignee | ||
Comment 1•9 years ago
|
||
Arthur, can you help me check this patch ? The main change in this file is that I removed observers for "ril.cf.XXXX.enabled" / "ril.cf.XXXX.number". With dialogService support, we can easily use returned value to do following works instead of observing keys and accessing input values from different panels directly.
Attachment #8541400 -
Flags: review?(arthur.chen)
Comment 2•9 years ago
|
||
Comment on attachment 8541400 [details] [review] patch on master It works well! However, I found the scripts for the four panels are the same. I would suggest make the four html files share the same panel module.
Attachment #8541400 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8541400 [details] [review] patch on master Thanks Arthur, the reason why I tried to make them in separate scripts is because I assumed we may need to customize each panel in the future. For now, I think we can compress all of them into one script and only separate them when needed. Hope this updated patch looks nice to you, thanks !
Attachment #8541400 -
Flags: review?(arthur.chen)
Comment 4•9 years ago
|
||
Comment on attachment 8541400 [details] [review] patch on master Sorry for the late review. There are conflict when merging to master because the call barring feature changes the structure of the panels. Call forwarding items have been moved to a separate panel, so we might need a new module for it.
Attachment #8541400 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8541400 [details] [review] patch on master Sure, it would be nice that we integrate these four subpanls under a standalone menu. For this updated patch, I did rebase to latest master and all functionalities work nice, Arthur, can you help me review this again ? thanks ! Note: this patch can be treated as the first step to refactor call settings as AMD module.
Attachment #8541400 -
Flags: review?(arthur.chen)
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 6•9 years ago
|
||
Comment on attachment 8541400 [details] [review] patch on master Good job! r=me with the nits addressed, thanks!
Attachment #8541400 -
Flags: review?(arthur.chen) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Thanks Arthur, merged at gaia/master : https://github.com/mozilla-b2g/gaia/commit/180b9d19bb04bbdebee78fe3022ecd6fd409c983
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
blocking-b2g: backlog → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•