[Settings][Dialog] call_settings/fdn/authorized_numbers/add_contact should be shown as a dialog

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: eragonj, Assigned: eragonj)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(tracking-b2g:+)

Details

Attachments

(1 attachment)

As title, call_settings/fdn/authorized_numbers/add_contact should be shown as a dialog. We should use settings dialog to show it.
blocking-b2g: --- → backlog
tracking-b2g: --- → +
Assignee: nobody → ejchen
Created attachment 8539958 [details] [review]
patch on master

Arthur, can you help me review this patch ? In this patch, I use dialogService to show the fdnDialog and removed some hacks we made last year. Hope this patch looks nice to you, thanks !
Attachment #8539958 - Flags: review?(arthur.chen)
Comment on attachment 8539958 [details] [review]
patch on master

Good work! r=me with the comment addressed, thanks!
Attachment #8539958 - Flags: review?(arthur.chen) → review+
Thanks all, merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/5f73fb1537fe66352d44b244c89d32013e1f2f71
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.