Closed
Bug 1103812
Opened 11 years ago
Closed 11 years ago
[Settings][Dialog] call_settings/fdn/authorized_numbers/add_contact should be shown as a dialog
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(tracking-b2g:+)
RESOLVED
FIXED
| tracking-b2g | + |
People
(Reporter: eragonj, Assigned: eragonj)
References
Details
Attachments
(1 file)
As title, call_settings/fdn/authorized_numbers/add_contact should be shown as a dialog. We should use settings dialog to show it.
|
||
Updated•11 years ago
|
blocking-b2g: --- → backlog
tracking-b2g:
--- → +
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ejchen
|
|
Assignee | |
Comment 1•11 years ago
|
||
Arthur, can you help me review this patch ? In this patch, I use dialogService to show the fdnDialog and removed some hacks we made last year. Hope this patch looks nice to you, thanks !
Attachment #8539958 -
Flags: review?(arthur.chen)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8539958 [details] [review]
patch on master
Good work! r=me with the comment addressed, thanks!
Attachment #8539958 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks all, merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/5f73fb1537fe66352d44b244c89d32013e1f2f71
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
blocking-b2g: backlog → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•