Closed Bug 1103814 Opened 10 years ago Closed 10 years ago

[Settings][Dialog] cellular/apn/APN_editor should be shown as a dialog

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:+)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g +

People

(Reporter: eragonj, Assigned: arthurcc)

References

Details

Attachments

(1 file)

link to https://github.com/mozilla-b2g/gaia/pull/27013
182 bytes, text/html
eragonj
: review+
Details 
As title, cellular/apn/APN_editor should be shown as a dialog. We should use settings dialog to show it.
blocking-b2g: --- → backlog
tracking-b2g: --- → +
Assignee: nobody → arthur.chen
EJ, could you help review the patch? The API was extended as what we discussed to support controlling the style of the button. Thanks.
Attachment #8541479 - Flags: review?(ejchen)
Comment on attachment 8541479 [details]
link to https://github.com/mozilla-b2g/gaia/pull/27013

Thanks Arthur ! r+ with one critical bug fixed.
Attachment #8541479 - Flags: review?(ejchen) → review+
master: 145d65561b80442c067892c22cc1704644396cc1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: