1103815 - [Settings][Dialog] internet_sharing/hotspot_settings should be shown as a dialog

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

As title, internet_sharing/hotspot_settings should be shown as a dialog. We should use settings dialog to show it.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master (2.2)

Arthur, can you help me review this simple patch ? thanks ;)

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8529545 [details] [review]
patch on master (2.2)

r=me with the nits addressed, thanks.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8529545 [details] [review]
patch on master (2.2)

Jenny, we are going to apply the new way of opening dialogs in settings app. In the end all the dialogs will be opened in the way that the patch shows.

Could you help review the transition of displaying the dialog and the style of the button that opens the dialog? Thanks!

Comment 4

[Jenny Lee]

Comment on attachment 8529545 [details] [review]
patch on master (2.2)

Looks good! one small thing, please tune the transition time to match the fade in/fade out time we have for dialog (ex. value selector). Thanks!

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

@Jenny, I am working on all related bugs and because this bug has been passed on CI, I'll merge it first and fix the transition time on another bug, thanks !

Merged into Gaia/master: https://github.com/mozilla-b2g/gaia/commit/303a5f8707e35e00b90b0475f26ecb364bd7dc59