[Bluetooth] Port Bug 1091588 to bluetooth2

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

Comment hidden (empty)
Created attachment 8528379 [details] [diff] [review]
[01] Bug 1103872: Add helpers for Bluetooth daemon Handsfree support
Attachment #8528379 - Flags: review?(btian)
Created attachment 8528380 [details] [diff] [review]
[02] Bug 1103872: Add Handsfree module for Bluetooth daemon
Attachment #8528380 - Flags: review?(btian)
Created attachment 8528381 [details] [diff] [review]
[03] Bug 1103872: Add Handsfree interface for Bluetooth daemon
Attachment #8528381 - Flags: review?(btian)
Created attachment 8528382 [details] [diff] [review]
[04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon
Attachment #8528382 - Flags: review?(btian)

Comment 5

4 years ago
Comment on attachment 8528379 [details] [diff] [review]
[01] Bug 1103872: Add helpers for Bluetooth daemon Handsfree support

Review of attachment 8528379 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8528379 - Flags: review?(btian) → review+

Comment 6

4 years ago
Comment on attachment 8528380 [details] [diff] [review]
[02] Bug 1103872: Add Handsfree module for Bluetooth daemon

Review of attachment 8528380 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8528380 - Flags: review?(btian) → review+

Comment 7

4 years ago
Comment on attachment 8528381 [details] [diff] [review]
[03] Bug 1103872: Add Handsfree interface for Bluetooth daemon

Review of attachment 8528381 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with typo addressed.

::: dom/bluetooth2/bluedroid/BluetoothDaemonHandsfreeInterface.h
@@ +331,5 @@
> +
> +  enum {
> +    MODE_HEADSET = 0x00,
> +    MODE_NARROWBAND_SPEECH = 0x01,
> +    MODE_NARRAWBAND_WIDEBAND_SPEECH = 0x02

typo: NARR'O'WBAND_WIDEBAND
Attachment #8528381 - Flags: review?(btian) → review+

Comment 8

4 years ago
Comment on attachment 8528382 [details] [diff] [review]
[04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon

Review of attachment 8528382 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8528382 - Flags: review?(btian) → review+
Created attachment 8530228 [details] [diff] [review]
[04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon (v2)

Changes since v1:

  - fixed typo in enum constant
Attachment #8528382 - Attachment is obsolete: true
Attachment #8530228 - Flags: review+
Attachment #8530228 - Attachment is obsolete: true
Comment on attachment 8528382 [details] [diff] [review]
[04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon

Restoring correct patch [04](v1)
Attachment #8528382 - Attachment is obsolete: false
Created attachment 8530230 [details] [diff] [review]
[03] Bug 1103872: Add Handsfree interface for Bluetooth daemon (v2)

Changes since v1:

  - fixed typo in enum constant
Attachment #8528381 - Attachment is obsolete: true
Attachment #8530230 - Flags: review+
You need to log in before you can comment on or make changes to this bug.