Closed Bug 1103872 Opened 10 years ago Closed 10 years ago

[Bluetooth] Port Bug 1091588 to bluetooth2

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(4 files, 2 obsolete files)

[01] Bug 1103872: Add helpers for Bluetooth daemon Handsfree support
24.50 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
[02] Bug 1103872: Add Handsfree module for Bluetooth daemon
41.48 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
[04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon
6.50 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
[03] Bug 1103872: Add Handsfree interface for Bluetooth daemon (v2)
11.79 KB, patch
tzimmermann
: review+
Details | Diff | Splinter Review
No description provided.
Comment on attachment 8528379 [details] [diff] [review] [01] Bug 1103872: Add helpers for Bluetooth daemon Handsfree support Review of attachment 8528379 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8528379 - Flags: review?(btian) → review+
Comment on attachment 8528380 [details] [diff] [review] [02] Bug 1103872: Add Handsfree module for Bluetooth daemon Review of attachment 8528380 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8528380 - Flags: review?(btian) → review+
Comment on attachment 8528381 [details] [diff] [review] [03] Bug 1103872: Add Handsfree interface for Bluetooth daemon Review of attachment 8528381 [details] [diff] [review]: ----------------------------------------------------------------- r=me with typo addressed. ::: dom/bluetooth2/bluedroid/BluetoothDaemonHandsfreeInterface.h @@ +331,5 @@ > + > + enum { > + MODE_HEADSET = 0x00, > + MODE_NARROWBAND_SPEECH = 0x01, > + MODE_NARRAWBAND_WIDEBAND_SPEECH = 0x02 typo: NARR'O'WBAND_WIDEBAND
Attachment #8528381 - Flags: review?(btian) → review+
Comment on attachment 8528382 [details] [diff] [review] [04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon Review of attachment 8528382 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8528382 - Flags: review?(btian) → review+
Changes since v1: - fixed typo in enum constant
Attachment #8528382 - Attachment is obsolete: true
Attachment #8530228 - Flags: review+
Attachment #8530228 - Attachment is obsolete: true
Comment on attachment 8528382 [details] [diff] [review] [04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon Restoring correct patch [04](v1)
Attachment #8528382 - Attachment is obsolete: false
Changes since v1: - fixed typo in enum constant
Attachment #8528381 - Attachment is obsolete: true
Attachment #8530230 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: