Closed Bug 1103992 Opened 5 years ago Closed 5 years ago

Placeholder text on about:home should be hidden

Categories

(Firefox :: Search, defect)

34 Branch
x86
All
defect
Not set

Tracking

()

VERIFIED FIXED
Tracking Status
firefox34 --- verified
firefox35 --- unaffected
firefox36 --- unaffected

People

(Reporter: phlsa, Assigned: Felipe)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image purple text
The placeholder text in the search field on about:home should be gray, not purple.
Attached patch Patch (obsolete) — Splinter Review
There's a |color: blue;| at https://hg.mozilla.org/releases/mozilla-beta/rev/27505b6035ef#l1.37 that seems to have been added by accident. Just removing it makes the placeholder text gray again: http://i.imgur.com/u6xBqyx.png
Assignee: nobody → florian
Attachment #8527680 - Flags: review?(felipc)
Summary: Placeholder text on about:home is purple (should be gray) → Placeholder text on about:home should be hidden
Attached patch placeholder.diffSplinter Review
Edited the title, as the original idea was to fully hide the placeholder. That's what we had in the bug in bug 1101122, but as I was attempting to do it through display: none or visibility, I left some leftover debugging in my patch queue. We concluded that they do not take effect in the ::-moz-placeholder, and therefore went with color: transparent.
Attachment #8527680 - Attachment is obsolete: true
Attachment #8527680 - Flags: review?(felipc)
Attachment #8527690 - Flags: review+
https://hg.mozilla.org/releases/mozilla-beta/rev/3511b01f24ce
Assignee: florian → felipc
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Version: 36 Branch → 34 Branch
QA Contact: petruta.rasa
No text is shown on about:home using Firefox 34.0 RC build (20141124205320) under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OSX 10.9.5.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.