1103992 - Placeholder text on about:home should be hidden

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: purple text

The placeholder text in the search field on about:home should be gray, not purple.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

There's a |color: blue;| at https://hg.mozilla.org/releases/mozilla-beta/rev/27505b6035ef#l1.37 that seems to have been added by accident. Just removing it makes the placeholder text gray again: http://i.imgur.com/u6xBqyx.png

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: placeholder.diff

Edited the title, as the original idea was to fully hide the placeholder. That's what we had in the bug in bug 1101122, but as I was attempting to do it through display: none or visibility, I left some leftover debugging in my patch queue. We concluded that they do not take effect in the ::-moz-placeholder, and therefore went with color: transparent.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3511b01f24ce

Comment 4

[Petruta Horea [:phorea], Desktop QA]

No text is shown on about:home using Firefox 34.0 RC build (20141124205320) under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OSX 10.9.5.