1104105 - [FFAndroid] PIN text box cannot be focused after a wrong PIN is entered

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Iulian Timis]

Steps to reproduce:
1. Load MP-stage homepage logged in on your Android device.
2. Search for a paid app.
3. Press the Price button to initiate a purchase.
4. Enter a wrong PIN and press the Enter button.
5. Focus the PIN text box to re-enter the PIN.

Expected results:
The numeric keyboard is displayed and the user is able to re-enter the PIN.

Actual results:
The PIN text box cannot be focused and the PIN cannot be re-entered.

Notes/Issues:
Verified on FF33 (Android 4.2.1).

Comment 1

[Stuart Colville [:muffinresearch]]

I can repro this. I've checked - it doesn't appear to be anything new. The cause looks to be the window.focus that we do as a workaround for focus issues in the trusted UI. We need to conditionally not do that for Android and that should fix it.

Comment 2

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/spartacus/pull/165

Comment 3

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/spartacus/commit/ade9c44d56793c6d4a1d14202d62706f2e4971ec

Comment 4

[Iulian Timis]

I can still reproduce this issue in https://marketplace.allizom.org/ on FF 34 (Android 4.2.1)

Comment 5

[Stuart Colville [:muffinresearch]]

(In reply to Iulian Timis from comment #4)
> I can still reproduce this issue in https://marketplace.allizom.org/ on FF
> 34 (Android 4.2.1)

This wasn't on stage yet. I've updated the milestone to reflect what it should be.

Comment 6

[Stuart Colville [:muffinresearch]]

Hmm re-testing this it's intemittently still happening on FFAndroid 34 / on an s3.

Comment 7

[Stuart Colville [:muffinresearch]]

Talking to JulianT and running through this bug we discovered this un-desirable state still occurs only when using the enter key on the android keyboard but not when using the submit button. Going to double check there's nothing odd in the submit code and then file a platform bug once I've confirmed it's not our code.

Comment 8

[Stuart Colville [:muffinresearch]]

Ah found that the code that attempts to disable the button is causing the behaviour on FFAndroid. 

New PR which should fix it is here: https://github.com/mozilla/spartacus/pull/179

Comment 9

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/spartacus/commit/a2807e9f5e7b2343dceca21ddcfa234b75a71bf2

Comment 10

[Iulian Timis]

Verified as fixed in https://marketplace.allizom.org/ on FF 34 (Android 4.2.1).
Attaching postfix screenshot.
Closing bug.

Comment 11

[Iulian Timis]

Attachment: postfix wrong pin enter.png