Closed
Bug 1104306
Opened 10 years ago
Closed 10 years ago
Re-whitelist https://www.mozilla.org for uitour on Fx34
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
Tracking | Status | |
---|---|---|
firefox34 | + | verified |
firefox35 | --- | unaffected |
firefox36 | --- | unaffected |
firefox37 | --- | unaffected |
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(2 files, 1 obsolete file)
We should re-whitelist https://www.mozilla.org for the uitour permission on Fx34 otherwise ~10% of the visitors to the tour page won't get the full tour experience as none of the UITour APIs will work.
This is to workaround the lack of bug 1050080 on Fx34.
Flags: firefox-backlog+
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8527955 -
Flags: review?(dolske)
Assignee | ||
Comment 2•10 years ago
|
||
/r/949 - Bug 1104306 - Re-whitelist https://www.mozilla.org for uitour on Fx34. r=dolske
Pull down this commit:
hg pull review -r 1ac3ab32dc0c53805a1bf5fb938e8e22502e86c5
Comment 3•10 years ago
|
||
Hi Matt, can you provide a point value.
Iteration: --- → 36.3
Flags: qe-verify?
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 4•10 years ago
|
||
That is a beta patch btw. since 35+ isn't affected.
I tested this manually by modifying browser.uitour.whitelist.add.340 in the latest Beta build.
STR:
In a build without this fix (e.g. 33):
1) History => Clear Recent History
2) Expand details section (if not already)
3) Check only "Site preferences" time period doesn't matter. Click Clear Now.
Update to Fx34.
4) The whatsnew page should load e.g. https://www.mozilla.org/en-US/firefox/34.0/whatsnew/ (not ready yet)
Actual result:
The interactive tour doesn't happen. E.g. no info panel
Expected result:
The interactive tour happens
Assignee | ||
Updated•10 years ago
|
Points: --- → 1
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(MattN+bmo)
Updated•10 years ago
|
Attachment #8527955 -
Flags: review?(dolske) → review+
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → Firefox 34
Assignee | ||
Comment 7•10 years ago
|
||
This won't work since the pref browser.uitour.whitelist.add.340 existed in 33 despite it's name.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•10 years ago
|
Attachment #8527955 -
Flags: review+ → review?(dolske)
Assignee | ||
Comment 8•10 years ago
|
||
/r/949 - Backed out changeset 4a20162dd1a8 since it won't work for users who used 32 or higher. a=dolske
/r/971 - Bug 1104306 - Re-whitelist https://www.mozilla.org for uitour on Fx34. r=dolske a=gavin/dolske
Pull down these commits:
hg pull review -r 676a18a5640e44e9610da3e21501dd674875c80e
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8527955 [details]
MozReview Request: bz://1104306/MattN
Approval Request Comment
[Feature/regressing bug #]: Bug 1050080 not being on beta 34
[User impact if declined]: No UITour functionality for ~10% of users.
[Describe test coverage new/current, TBPL]: None. Manual testing by me.
[Risks and why]: Low risk re-running code we ran in earlier versions
[String/UUID change made/needed]: None
Attachment #8527955 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 10•10 years ago
|
||
/r/949 - Backed out changeset 4a20162dd1a8 since it won't work for users who used 32 or higher. a=dolske
/r/971 - Bug 1104306 - Re-whitelist https://www.mozilla.org for uitour on Fx34. r=dolske a=gavin/dolske
Pull down these commits:
hg pull review -r 545ce066516af077b2ae8043a50c8f8822967f20
Assignee | ||
Comment 11•10 years ago
|
||
Since the about:home whitelist was uplifted to 32, I decided to re-whitelist about:home too since I've heard ideas of using snippets in 34.
Updated•10 years ago
|
Attachment #8527955 -
Flags: review?(dolske) → review+
Comment 12•10 years ago
|
||
Assignee | ||
Comment 13•10 years ago
|
||
backout: https://hg.mozilla.org/releases/mozilla-beta/rev/b5cd45a6e164
new version: https://hg.mozilla.org/releases/mozilla-beta/rev/c8ff4c93ee85
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 14•10 years ago
|
||
Updated•10 years ago
|
QA Contact: catalin.varga
Comment 15•10 years ago
|
||
Comment on attachment 8527955 [details]
MozReview Request: bz://1104306/MattN
Previously provided verbal approval. Adding approval to the bug.
Attachment #8527955 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 16•10 years ago
|
||
Verified as fixed using the following environment:
FF 34
Build Id:20141125180439
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x64
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 17•9 years ago
|
||
Attachment #8527955 -
Attachment is obsolete: true
Attachment #8618712 -
Flags: review+
Attachment #8618713 -
Flags: review+
Assignee | ||
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•