1104306 - Re-whitelist https://www.mozilla.org for uitour on Fx34

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Matthew N. [:MattN]]

We should re-whitelist https://www.mozilla.org for the uitour permission on Fx34 otherwise ~10% of the visitors to the tour page won't get the full tour experience as none of the UITour APIs will work.

This is to workaround the lack of bug 1050080 on Fx34.

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1104306/MattN

Comment 2

[Matthew N. [:MattN]]

/r/949 - Bug 1104306 - Re-whitelist https://www.mozilla.org for uitour on Fx34. r=dolske

Pull down this commit:

hg pull review -r 1ac3ab32dc0c53805a1bf5fb938e8e22502e86c5

Comment 3

[Marco Mucci [:MarcoM]]

Hi Matt, can you provide a point value.

Comment 4

[Matthew N. [:MattN]]

That is a beta patch btw. since 35+ isn't affected.

I tested this manually by modifying browser.uitour.whitelist.add.340 in the latest Beta build.

STR:
In a build without this fix (e.g. 33):
1) History => Clear Recent History
2) Expand details section (if not already)
3) Check only "Site preferences" time period doesn't matter. Click Clear Now.
Update to Fx34.
4) The whatsnew page should load e.g. https://www.mozilla.org/en-US/firefox/34.0/whatsnew/ (not ready yet)

Actual result:
The interactive tour doesn't happen. E.g. no info panel

Expected result:
The interactive tour happens

Comment 5

[Justin Dolske [:Dolske]]

https://reviewboard.mozilla.org/r/947/#review521

Ship It!

Comment 6

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4a20162dd1a8

Comment 7

[Matthew N. [:MattN]]

This won't work since the pref browser.uitour.whitelist.add.340 existed in 33 despite it's name.

Comment 8

[Matthew N. [:MattN]]

/r/949 - Backed out changeset 4a20162dd1a8 since it won't work for users who used 32 or higher. a=dolske
/r/971 - Bug 1104306 - Re-whitelist https://www.mozilla.org for uitour on Fx34. r=dolske a=gavin/dolske

Pull down these commits:

hg pull review -r 676a18a5640e44e9610da3e21501dd674875c80e

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 8527955 [details]
MozReview Request: bz://1104306/MattN

Approval Request Comment
[Feature/regressing bug #]: Bug 1050080 not being on beta 34
[User impact if declined]: No UITour functionality for ~10% of users.
[Describe test coverage new/current, TBPL]: None. Manual testing by me.
[Risks and why]: Low risk re-running code we ran in earlier versions
[String/UUID change made/needed]: None

Comment 10

[Matthew N. [:MattN]]

/r/949 - Backed out changeset 4a20162dd1a8 since it won't work for users who used 32 or higher. a=dolske
/r/971 - Bug 1104306 - Re-whitelist https://www.mozilla.org for uitour on Fx34. r=dolske a=gavin/dolske

Pull down these commits:

hg pull review -r 545ce066516af077b2ae8043a50c8f8822967f20

Comment 11

[Matthew N. [:MattN]]

Since the about:home whitelist was uplifted to 32, I decided to re-whitelist about:home too since I've heard ideas of using snippets in 34.

Comment 12

[Justin Dolske [:Dolske]]

https://reviewboard.mozilla.org/r/947/#review525

Ship It!

Comment 13

[Matthew N. [:MattN]]

backout:     https://hg.mozilla.org/releases/mozilla-beta/rev/b5cd45a6e164
new version: https://hg.mozilla.org/releases/mozilla-beta/rev/c8ff4c93ee85

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/c8ff4c93ee85

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8527955 [details]
MozReview Request: bz://1104306/MattN

Previously provided verbal approval. Adding approval to the bug.

Comment 16

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 34
Build Id:20141125180439
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x64

Comment 18

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1104306 - Re-whitelist https://www.mozilla.org for uitour on Fx34. r=dolske a=gavin/dolske

Comment 19

[Matthew N. [:MattN]]

Attachment: MozReview Request: Backed out changeset 4a20162dd1a8 since it won't work for users who used 32 or higher. a=dolske