1104338 - [b2g] we need root access on the b2g builds ( 2.2 )

Status: RESOLVED DUPLICATE of bug 1121045

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. flash the 2.2 build with a full flash
2. adb shell

Expected : root access
Actual: non root access

shell@flame:/ $ more default.prop
#
# ADDITIONAL_DEFAULT_PROPERTIES
#
ro.secure=1
ro.allow.mock.location=0
ro.debuggable=0
persist.sys.strict_op_enable=false
persist.sys.whitelist=/system/etc/whitelist_appops.xml
persist.sys.usb.config=diag,serial_smd,serial_tty,rmnet_bam,mass_storage
shell@flame:/

ro.secure=1 and ro.debuggable=0; meaning we don't have root access on these builds.

I think there's some sort of flag to give us root access during the build process?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I read on another bug that 'user' builds don't have root, and 'eng' builds do. Could you clarify which build you used ?

Comment 2

[Tony Chung [:tchung]]

i believe he used user builds.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hi, Nick.  I am using the user build.  QA tests on the user build and we do need root on that build in order to access various things such as the Crash Reports.

The engineering build has root.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

It seems to me this is a larger discussion. User builds are presumably not-root for a reason, but that isn't helpful for the QA use case.  I don't know enough about the B2G build system to say if there is some middle ground where we keep user-style build, but enabling root access, just for pvtbuilds. And if so, what consequences that has for other consumers of pvtbuilds. A global change to the build system is likely to affect partners builds.

Hoping mwu will have context here.

Comment 5

[Michael Wu [:mwu]]

userdebug builds might be a good alternative. It isn't root by default, but you can switch it to root with "adb root". It eliminates a lot of engineering build specific things too.

An alternative to that is using eng boot images with user system/data images.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I agree with Michael.  I just tried it on my phone.  I'm not sure if there's any issues coming out of this that we would have to prepare for (such as in automation).  I think once we make our adjustments in our scripts we should be fine.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Naoki, which option are you agreeing with ?

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

VARIANT=userdebug
vs
VARIANT=user

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

We only need one bug for this.