1104421 - Assert that MediaDecoderReader::Shutdown has been called in MediaDecoderReader's destructor

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

It'd be easier to catch problems like bug 1104357 if MediaDecoderReader was able to assert in its destructor that Shutdown() had been called.

An initial attempt at this patch required Shutdown() to always be called, but this revealed a huge amount of breakage on a try push.  I think it's more reasonable to assert that work done in the constructor is undone in the destructor, and work done in Init() is undone in Shutdown(), i.e. it should only be necessary to call Shutdown() if Init() succeeded.  Unfortunately, that currently requires modifying all existing reader subclasses.

Comment 1

[Matthew Gregan [:kinetik]]

One of the patches in bug 1104964 does this.