1104422 - Should use PBrowserOrId in WyciwygChannelChild::AsyncOpen

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Kershaw Chang [:kershaw]]

In WyciwygChannelChild::AsyncOpen[1], we should use PBrowserOrId to replace tabChild in SendAsyncOpen, otherwise it would not work in nested oop case.

[1] http://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp#663

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Use PBrowserOrId to replace tabChild in SendAsyncOpen

Hi Kershaw, 
please kindly help to check this patch.
Thanks.

Comment 2

[Kershaw Chang [:kershaw]]

Comment on attachment 8542036 [details] [diff] [review]
Use PBrowserOrId to replace tabChild in SendAsyncOpen

Review of attachment 8542036 [details] [diff] [review]:
-----------------------------------------------------------------

Overall it looks good.

::: netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp
@@ +661,5 @@
>      return NS_ERROR_ILLEGAL_VALUE;
>    }
>  
> +  PBrowserOrId browser = static_cast<ContentChild*>(Manager()->Manager())
> +                           ->GetBrowserOrId(tabChild);

nit: additional spaces

@@ +662,5 @@
>    }
>  
> +  PBrowserOrId browser = static_cast<ContentChild*>(Manager()->Manager())
> +                           ->GetBrowserOrId(tabChild);
> +                           

nit: trailing spaces

Comment 3

[James Cheng[:JamesCheng]]

Attachment: Bug 1104422 - Use PBrowserOrId to replace tabChild in SendAsyncOpen.

Hi Kershaw,
Thanks for the feedback and I've modified and upload the new patch as attachment.
Please confirm it.

Thanks.

Comment 4

[Kershaw Chang [:kershaw]]

I think we can start the review process now.

Hi Honza,

Could you help to look at this patch?

Thanks.

Comment 5

[James Cheng[:JamesCheng]]

Hi Honza,

The try server test result are as follows,

https://treeherder.mozilla.org/#/jobs?repo=try&revision=74554e1a91c7

Thanks.

Comment 6

[James Cheng[:JamesCheng]]

Attachment: 0001-Bug-1104422-Use-PBrowserOrId-to-replace-tabChild-in-.patch

Update reviewer name on patch

Comment 7

[James Cheng[:JamesCheng]]

Attachment: Bug-1104422-Use-PBrowserOrId-to-replace-tabChild-in-.patch r=honzab

Update patch message and delete redundant patches.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ea858252621

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ea858252621