Closed Bug 1104645 Opened 5 years ago Closed 5 years ago
Update the conditions regarding the number of digits displayed on the callscreen
Lines like: > if len(self.test_phone_number) <= 12 Are not valid anymore. The callscreen can display up to 22 digits. By the way, I think the constant should be put in the Page object as a Class constant. like > class CallScreen(object): > MAXIMUM_NUMBER_OF_DISPLAYED_DIGITS = 22 So we would have these checks in the tests: > > if len(self.test_phone_number) <= CallScreen.MAXIMUM_NUMBER_OF_DISPLAYED_DIGITS
> self.assertEqual(test_phone_number[:2], call_screen.outgoing_calling_contact[:2]) Another thing that crosses my mind, why do we check only for the first 2 digits if there is more than 12 digits? This change has been done in bug 925850. Do you remember anything, Viorela?
As I remember, here we were supposed to check for the phone number, except the first 2 digits. So it should be: self.assertEqual(test_phone_number[2:], call_screen.outgoing_calling_contact[2:] It's weird that we didn't notice this mistake before. We should update this assert too while working on this bug.
QA Whiteboard: [fxosqa-auto-backlog?] → [fxosqa-auto-backlog+]
Assignee: nobody → jlorenzo
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-s6][fxosqa-auto-points=1]
Comment on attachment 8534337 [details] [review] Gaia PR Looks good.
Attachment #8534337 - Flags: review?(martijn.martijn) → review+
Attachment #8534337 - Flags: review?(robert.chira) → review+
Comment on attachment 8534337 [details] [review] Gaia PR Merged in: https://github.com/mozilla-b2g/gaia/commit/6aa3134c2473b705fd78e5a2cf19281a061c9dd8
Attachment #8534337 - Flags: review?(viorela.ioia) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.