1104645 - Update the conditions regarding the number of digits displayed on the callscreen.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Lines like:
> if len(self.test_phone_number) <= 12

Are not valid anymore. The callscreen can display up to 22 digits. By the way, I think the constant should be put in the Page object as a Class constant. like

> class CallScreen(object):
>     MAXIMUM_NUMBER_OF_DISPLAYED_DIGITS = 22

So we would have these checks in the tests:

> > if len(self.test_phone_number) <= CallScreen.MAXIMUM_NUMBER_OF_DISPLAYED_DIGITS

Comment 1

[Johan Lorenzo [:jlorenzo]]

> self.assertEqual(test_phone_number[:2], call_screen.outgoing_calling_contact[:2])

Another thing that crosses my mind, why do we check only for the first 2 digits if there is more than 12 digits? This change has been done in bug 925850. Do you remember anything, Viorela?

Comment 2

[Viorela Ioia [:viorela]]

As I remember, here we were supposed to check for the phone number, except the first 2 digits. 
So it should be: self.assertEqual(test_phone_number[2:], call_screen.outgoing_calling_contact[2:]
It's weird that we didn't notice this mistake before.  

We should update this assert too while working on this bug.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 8534337 [details] [review]
Gaia PR

Looks good.

Comment 5

[Viorela Ioia [:viorela]]

Comment on attachment 8534337 [details] [review]
Gaia PR

Merged in: https://github.com/mozilla-b2g/gaia/commit/6aa3134c2473b705fd78e5a2cf19281a061c9dd8