Closed Bug 1104704 Opened 11 years ago Closed 11 years ago

Intermittent browser_chrome_share_web_result_test.js | Browser Chrome - Share Web Result share web result via e-mail

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cbook, Assigned: kgrandon)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

b2g_ubuntu64_vm mozilla-inbound opt test gaia-js-integration-2 https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4188922&repo=mozilla-inbound 04:19:57 INFO - TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_chrome_share_web_result_test.js | Browser Chrome - Share Web Result share web result via e-mail
This fails from the socket issue, but also within the e-mail app. Making a dummy app which accepts a share activity and outputs some details is probably a better thing to do here. I'll investigate.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Comment on attachment 8547844 [details] [review] [PullReq] KevinGrandon:bug_1104704_intermittent_browser_chrome_share_web_result_test to mozilla-b2g:master I think this is a better way of doing things. Review anyone?
Attachment #8547844 - Flags: review?(dale)
Attachment #8547844 - Flags: review?(chrislord.net)
Comment on attachment 8547844 [details] [review] [PullReq] KevinGrandon:bug_1104704_intermittent_browser_chrome_share_web_result_test to mozilla-b2g:master Couple of nits on the github page - looks much better. I'm not sure if I'm the best reviewer for this, so leaving dale's r? If you think I am, feel free to remove it (that goes for both of you).
Attachment #8547844 - Flags: review?(chrislord.net) → review+
Comment on attachment 8547844 [details] [review] [PullReq] KevinGrandon:bug_1104704_intermittent_browser_chrome_share_web_result_test to mozilla-b2g:master Looks good from me, I would really like to see a test run to make sure that this has fixed the issue though, not sure why this hasnt triggered a run, will try and chuck a PR up and trigger the runs in a sec Agree with the nits
Attachment #8547844 - Flags: review?(dale) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: