[Rooms] Move 'feedback' screen code to a reusable component

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: borjasalguero, Assigned: borjasalguero)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We are going to show the same 'feedback' screen in 'calls' and 'rooms', so we need to move this to a separate module.
Blocks: 1105176
(Assignee)

Updated

3 years ago
Assignee: nobody → borja.bugzilla
(Assignee)

Comment 1

3 years ago
Created attachment 8529941 [details] [review]
Pull Request

This patch contains the first movement in the direction of the lazy loading of the panels. Please let me know your feedback! Thanks!
Attachment #8529941 - Flags: feedback?(crdlc)
Comment on attachment 8529941 [details] [review]
Pull Request

Perfect!!! Good job
Attachment #8529941 - Flags: feedback?(crdlc) → feedback+
(Assignee)

Comment 3

3 years ago
Comment on attachment 8529941 [details] [review]
Pull Request

Updated the code after talking with Cristian, so now we can load a single panel regardless how many 'is' panels we have in our html.
I've included 'create' room lazy loading in order to confirm that this is working as expected.
Attachment #8529941 - Flags: review?(crdlc)
Comment on attachment 8529941 [details] [review]
Pull Request

Excellent job as always, thanks
Attachment #8529941 - Flags: review?(crdlc) → review+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.