Closed
Bug 1104731
Opened 10 years ago
Closed 10 years ago
[Rooms] Move 'feedback' screen code to a reusable component
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: borjasalguero, Assigned: borjasalguero)
References
Details
Attachments
(1 file)
We are going to show the same 'feedback' screen in 'calls' and 'rooms', so we need to move this to a separate module.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → borja.bugzilla
|
|
Assignee | |
Comment 1•10 years ago
|
||
This patch contains the first movement in the direction of the lazy loading of the panels. Please let me know your feedback! Thanks!
Attachment #8529941 -
Flags: feedback?(crdlc)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8529941 [details] [review]
Pull Request
Perfect!!! Good job
Attachment #8529941 -
Flags: feedback?(crdlc) → feedback+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8529941 [details] [review]
Pull Request
Updated the code after talking with Cristian, so now we can load a single panel regardless how many 'is' panels we have in our html.
I've included 'create' room lazy loading in order to confirm that this is working as expected.
Attachment #8529941 -
Flags: review?(crdlc)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8529941 [details] [review]
Pull Request
Excellent job as always, thanks
Attachment #8529941 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•