Closed Bug 1104748 Opened 6 years ago Closed 6 years ago

A long default search provider name can mess up the layout of the one-off buttons when the panel is small

Categories

(Firefox :: Search, defect)

34 Branch
defect
Not set
normal
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 36
Iteration:
37.1
Tracking Status
firefox34 + verified
firefox35 + verified
firefox36 + verified
firefox37 --- verified

People

(Reporter: avaida, Assigned: florian)

References

Details

Attachments

(1 file)

Reproducible on: Firefox 34.0 (build1 / 20141124205320).
Affected platform(s): Windows 7 64-bit, Windows 8 32-bit, Ubuntu 12.04 LTS 32-bit and Mac OS X 10.9.5.

STR:
1. Launch Firefox with a clean profile.
2. Click the magnifying glass icon from the search bar → choose "Change Search Settings".
3. Click "Add more search providers...".
4. Install two additional search providers from that list and restart the browser if asked.
5. Access https://bugzilla.mozilla.org from the Location Bar.
6. Click the magnifying glass icon from the search bar → choose "Add Bugzilla@Mozilla Search".
7. Click the menu button → go to "Search" → set the "Default Search Engine" to "Bugzilla@Mozilla".
8. Make the width of the browser window smaller and type in the Search Bar a random search term (e.g. example).

Expected result: The search pane's content is displayed properly in case of narrow browser windows.

Actual result: The search pane's content is cutoff by it's margin and there's no ellipsis used for longer strings.

Screenshot: http://i.imgur.com/23VNO8I.png
Possible duplicate of bug # 1104325
Summary: Resizing the window after installing additional search providers results in a cutoff search pane → A long default search provider name can mess up the layout of the one-off buttons when the panel is small
Attached patch FixSplinter Review
Assignee: nobody → florian
Attachment #8528509 - Flags: review?(felipc)
Attachment #8528509 - Flags: approval-mozilla-release?
Attachment #8528509 - Flags: approval-mozilla-beta?
Attachment #8528509 - Flags: review?(felipc) → review+
Screenshot without patch: http://i.imgur.com/oGhJeog.png and with the patch: http://i.imgur.com/9rUkMEQ.png
Comment on attachment 8528509 [details] [diff] [review]
Fix

Reviewed with Florian. Release+ Beta+
Attachment #8528509 - Flags: approval-mozilla-release?
Attachment #8528509 - Flags: approval-mozilla-release+
Attachment #8528509 - Flags: approval-mozilla-beta?
Attachment #8528509 - Flags: approval-mozilla-beta+
Verified fixed on Firefox 34.0 (build2 / 20141125180439) using Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 LTS 32-bit.

Although most of the pane's elements now react properly in this scenario, the "Change Search Settings" button is still showing this issue:
 - the button's label is still being cutoff (on all platforms),
 - on Linux, the bottom border of the button is completely missing.
Here's a screenshot that shows both of these side-effects: http://i.imgur.com/IHmoQX8.png.

Perhaps this should be treated in a separate bug. Florian, what do you think?
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(florian)
Resolution: --- → FIXED
Hi Florian, can you provide a point value.
Iteration: --- → 37.1
Flags: needinfo?(florian)
Flags: firefox-backlog?
Flags: firefox-backlog+
(In reply to Andrei Vaida, QA [:avaida] from comment #7)
> Verified fixed on Firefox 34.0 (build2 / 20141125180439) using Windows 7
> 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 LTS 32-bit.
> 
> Although most of the pane's elements now react properly in this scenario,
> the "Change Search Settings" button is still showing this issue:
>  - the button's label is still being cutoff (on all platforms),
>  - on Linux, the bottom border of the button is completely missing.
> Here's a screenshot that shows both of these side-effects:
> http://i.imgur.com/IHmoQX8.png.
> 
> Perhaps this should be treated in a separate bug. Florian, what do you think?

Yes, separate bug (if we think it needs fixing). I tested this yesterday and discussed it with Felipe. We agreed that the "Change Search Settings" button wasn't worth fixing for beta (I'm not even sure that cropping the text with an ellipsis would actually be better that the current cut-off text) because it doesn't mess up the layout of the rest of the panel like the header did.

Leaving this open because I expect to land the fix for Firefox 36 too.
Status: RESOLVED → REOPENED
Points: --- → 1
Flags: needinfo?(florian)
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/5c24bc95888c
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Verified fixed on Nightly 37.0a1 (2014-12-07) and Aurora 36.0a2 (2014-12-08) as well, using Windows 7 64-bit, Ubuntu 12.04 LTS 32-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Verified fixed on Firefox 35.0b6 (20141222200458) using Ubuntu 12.04 LTS 32-bit, Windows 8.1 64-bit and Mac OS X 10.9.5.
You need to log in before you can comment on or make changes to this bug.