1104748 - A long default search provider name can mess up the layout of the one-off buttons when the panel is small

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Andrei Vaida [:avaida]]

Reproducible on: Firefox 34.0 (build1 / 20141124205320).
Affected platform(s): Windows 7 64-bit, Windows 8 32-bit, Ubuntu 12.04 LTS 32-bit and Mac OS X 10.9.5.

STR:
1. Launch Firefox with a clean profile.
2. Click the magnifying glass icon from the search bar → choose "Change Search Settings".
3. Click "Add more search providers...".
4. Install two additional search providers from that list and restart the browser if asked.
5. Access https://bugzilla.mozilla.org from the Location Bar.
6. Click the magnifying glass icon from the search bar → choose "Add Bugzilla@Mozilla Search".
7. Click the menu button → go to "Search" → set the "Default Search Engine" to "Bugzilla@Mozilla".
8. Make the width of the browser window smaller and type in the Search Bar a random search term (e.g. example).

Expected result: The search pane's content is displayed properly in case of narrow browser windows.

Actual result: The search pane's content is cutoff by it's margin and there's no ellipsis used for longer strings.

Screenshot: http://i.imgur.com/23VNO8I.png

Comment 1

[Kamil Jozwiak [:kjozwiak]]

Possible duplicate of bug # 1104325

Comment 2

[Florian Quèze [:florian]]

Attachment: Fix

Comment 3

[Florian Quèze [:florian]]

Screenshot without patch: http://i.imgur.com/oGhJeog.png and with the patch: http://i.imgur.com/9rUkMEQ.png

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8528509 [details] [diff] [review]
Fix

Reviewed with Florian. Release+ Beta+

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c0c3429824fc

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-release/rev/c0c3429824fc

Comment 7

[Andrei Vaida [:avaida]]

Verified fixed on Firefox 34.0 (build2 / 20141125180439) using Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 LTS 32-bit.

Although most of the pane's elements now react properly in this scenario, the "Change Search Settings" button is still showing this issue:
 - the button's label is still being cutoff (on all platforms),
 - on Linux, the bottom border of the button is completely missing.
Here's a screenshot that shows both of these side-effects: http://i.imgur.com/IHmoQX8.png.

Perhaps this should be treated in a separate bug. Florian, what do you think?

Comment 8

[Marco Mucci [:MarcoM]]

Hi Florian, can you provide a point value.

Comment 9

[Florian Quèze [:florian]]

(In reply to Andrei Vaida, QA [:avaida] from comment #7)
> Verified fixed on Firefox 34.0 (build2 / 20141125180439) using Windows 7
> 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 LTS 32-bit.
> 
> Although most of the pane's elements now react properly in this scenario,
> the "Change Search Settings" button is still showing this issue:
>  - the button's label is still being cutoff (on all platforms),
>  - on Linux, the bottom border of the button is completely missing.
> Here's a screenshot that shows both of these side-effects:
> http://i.imgur.com/IHmoQX8.png.
> 
> Perhaps this should be treated in a separate bug. Florian, what do you think?

Yes, separate bug (if we think it needs fixing). I tested this yesterday and discussed it with Felipe. We agreed that the "Change Search Settings" button wasn't worth fixing for beta (I'm not even sure that cropping the text with an ellipsis would actually be better that the current cut-off text) because it doesn't mess up the layout of the rest of the panel like the header did.

Leaving this open because I expect to land the fix for Firefox 36 too.

Comment 10

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/5c24bc95888c

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5c24bc95888c

Comment 12

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3c2c29abfa35

Comment 13

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 37.0a1 (2014-12-07) and Aurora 36.0a2 (2014-12-08) as well, using Windows 7 64-bit, Ubuntu 12.04 LTS 32-bit and Mac OS X 10.9.5.

Comment 14

[Andrei Vaida [:avaida]]

Verified fixed on Firefox 35.0b6 (20141222200458) using Ubuntu 12.04 LTS 32-bit, Windows 8.1 64-bit and Mac OS X 10.9.5.