Closed Bug 1104855 Opened 7 years ago Closed 7 years ago

Don't rebuild the omnijar on every Gradle build

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file, 1 obsolete file)

Pretty clear win here: we're currently forcing a stage-package of the omnijar on every Gradle build.  The solution is to make the Omnijar Gradle task know its inputs and outputs, so that Gradle knows when the task's target is out of date.
Attachment #8528479 - Flags: review?(margaret.leibovic)
/r/995 - Bug 1104855 - Don't rebuild the omnijar on every Gradle build. r=margaret

Pull down this commit:

hg pull review -r 04b3628ecbbbd9b2d2e2990139b2a76a35f31bdb
Attachment #8528479 - Flags: review?(margaret.leibovic) → review+
https://reviewboard.mozilla.org/r/993/#review549

Rubber stamp!

::: mobile/android/base/Makefile.in
(Diff revision 1)
> -gradle-targets: $(abspath $(DIST)/fennec/$(OMNIJAR_NAME))

Testing out RB comments. Looks good!
https://hg.mozilla.org/mozilla-central/rev/a26cfc08f359
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Attachment #8528479 - Attachment is obsolete: true
Attachment #8618721 - Flags: review+
Component: Build Config → Build Config & IDE Support
Product: Core → Firefox for Android
Target Milestone: mozilla36 → ---
Product: Firefox for Android → Firefox Build System
You need to log in before you can comment on or make changes to this bug.