38 bytes, text/x-review-board-request
Pretty clear win here: we're currently forcing a stage-package of the omnijar on every Gradle build. The solution is to make the Omnijar Gradle task know its inputs and outputs, so that Gradle knows when the task's target is out of date.
Created attachment 8528479 [details] MozReview Request: bz://1104855/nalexander
Attachment #8528479 - Flags: review?(margaret.leibovic)
/r/995 - Bug 1104855 - Don't rebuild the omnijar on every Gradle build. r=margaret Pull down this commit: hg pull review -r 04b3628ecbbbd9b2d2e2990139b2a76a35f31bdb
Attachment #8528479 - Flags: review?(margaret.leibovic) → review+
https://reviewboard.mozilla.org/r/993/#review549 Rubber stamp! ::: mobile/android/base/Makefile.in (Diff revision 1) > -gradle-targets: $(abspath $(DIST)/fennec/$(OMNIJAR_NAME)) Testing out RB comments. Looks good!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8528479 [details] MozReview Request: bz://1104855/nalexander
Created attachment 8618721 [details] MozReview Request: Bug 1104855 - Don't rebuild the omnijar on every Gradle build. r=margaret
Component: Build Config → Build Config & IDE Support
Product: Core → Firefox for Android
Target Milestone: mozilla36 → ---
You need to log in before you can comment on or make changes to this bug.