Don't rebuild the omnijar on every Gradle build

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Pretty clear win here: we're currently forcing a stage-package of the omnijar on every Gradle build.  The solution is to make the Omnijar Gradle task know its inputs and outputs, so that Gradle knows when the task's target is out of date.
(Assignee)

Comment 1

4 years ago
Created attachment 8528479 [details]
MozReview Request: bz://1104855/nalexander
Attachment #8528479 - Flags: review?(margaret.leibovic)
(Assignee)

Comment 2

4 years ago
/r/995 - Bug 1104855 - Don't rebuild the omnijar on every Gradle build. r=margaret

Pull down this commit:

hg pull review -r 04b3628ecbbbd9b2d2e2990139b2a76a35f31bdb

Updated

4 years ago
Attachment #8528479 - Flags: review?(margaret.leibovic) → review+

Comment 3

4 years ago
https://reviewboard.mozilla.org/r/993/#review549

Rubber stamp!

::: mobile/android/base/Makefile.in
(Diff revision 1)
> -gradle-targets: $(abspath $(DIST)/fennec/$(OMNIJAR_NAME))

Testing out RB comments. Looks good!
https://hg.mozilla.org/mozilla-central/rev/a26cfc08f359
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
(Assignee)

Comment 6

3 years ago
Comment on attachment 8528479 [details]
MozReview Request: bz://1104855/nalexander
Attachment #8528479 - Attachment is obsolete: true
Attachment #8618721 - Flags: review+
(Assignee)

Comment 7

3 years ago
Created attachment 8618721 [details]
MozReview Request: Bug 1104855 - Don't rebuild the omnijar on every Gradle build. r=margaret
(Assignee)

Updated

a year ago
Component: Build Config → Build Config & IDE Support
Product: Core → Firefox for Android
Target Milestone: mozilla36 → ---
You need to log in before you can comment on or make changes to this bug.