Closed Bug 1104856 Opened 7 years ago Closed 7 years ago

Active state for the selected devtools tab is wrong

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

I'm assuming this a regression of bug 1102369.  When active, the selected tab is getting the normal active state as a background.
This is unfortunate, but we need this workaround for now to make sure that we are overriding the :hover:active state (which includes the .theme-light/.theme-dark prefix since they are using special, non-variable, colors).
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8528470 - Flags: review?(vporof)
Attachment #8528470 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/4f555b40f01e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
I don't see why you didn't use the :not() selector :
.devtools-tab:not([selected]):hover:active {
  // Active state code
}
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.