Closed
Bug 1104856
Opened 10 years ago
Closed 10 years ago
Active state for the selected devtools tab is wrong
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
|
995 bytes,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
I'm assuming this a regression of bug 1102369. When active, the selected tab is getting the normal active state as a background.
|
Assignee | |
Comment 1•10 years ago
|
||
This is unfortunate, but we need this workaround for now to make sure that we are overriding the :hover:active state (which includes the .theme-light/.theme-dark prefix since they are using special, non-variable, colors).
|
||
Updated•10 years ago
|
Attachment #8528470 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
|
||
Comment 4•10 years ago
|
||
I don't see why you didn't use the :not() selector :
.devtools-tab:not([selected]):hover:active {
// Active state code
}
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•