1104955 - Implement IDL [Unscopable]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Anne (:annevk)]

If we implement @@unscopables and [Unscopable] we can implement some new features in DOM and improve existing features.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Bug 1054759 needs to happen first, obviously.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Add parsing for [Unscopeable] in IDL

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make codegen output a list of unscopable names that we can then pass to CreateInterfaceObjects

Note that this does not take into account the exposed/enabled state of the
relevant properties.  This should be OK, I hope.  Taking that state into account
would be rather annoying, unfortunately.  We could make codegen fail if
something is conditionally exposed and unscopable, if desired...

Also note that I'm using the ES6 spelling of "unscopable", which seems more
correct to me in terms the way "able" is usually added to words than the IDL
"unscopeable".

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Pass our unscopable names to CreateInterfaceObjects and have it define the right thing on the prototype

Comment 5

[Boris Zbarsky [:bzbarsky]]

Spec is changing in terms spelling (note comment 3 for comparison), so going to update the relevant bits of these patches.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Add parsing for [Unscopeable] in IDL

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make codegen output a list of unscopable names that we can then pass to CreateInterfaceObjects

Note that this does not take into account the exposed/enabled state of the
relevant properties.  This should be OK, I hope.  Taking that state into account
would be rather annoying, unfortunately.  We could make codegen fail if
something is conditionally exposed and unscopable, if desired...

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Pass our unscopable names to CreateInterfaceObjects and have it define the right thing on the prototype

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8735146 [details] [diff] [review]
part 1.  Add parsing for [Unscopeable] in IDL

Review of attachment 8735146 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/parser/WebIDL.py
@@ +4110,5 @@
>                                    [attr.location, self.location])
> +        elif identifier == "Unscopable":
> +            if not attr.noArguments():
> +                raise WebIDLError("[Unscopable] must take no arguments",
> +                                  [attr.location])            

nit: whitespace at EOL

@@ +4818,5 @@
>                                    [attr.location, self.location])
> +        elif identifier == "Unscopable":
> +            if not attr.noArguments():
> +                raise WebIDLError("[Unscopable] must take no arguments",
> +                                  [attr.location])            

and here

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/483533fede8d
https://hg.mozilla.org/integration/mozilla-inbound/rev/75898c3d4bb2
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fde05270e25

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/483533fede8d
https://hg.mozilla.org/mozilla-central/rev/75898c3d4bb2
https://hg.mozilla.org/mozilla-central/rev/2fde05270e25

Comment 12

[Jean-Yves Perrier [:teoli]]

Added ddn so that we update our guide on what info is available in the webidl of an interface, and how to translate it in the docs.