Closed Bug 1104965 Opened 10 years ago Closed 10 years ago

(ios) LoginViewController never deinits

Categories

(Firefox for iOS :: Firefox Accounts, defect)

Product:
Firefox for iOS
Component:
Firefox Accounts
Platform:
All
iOS 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Pull request
46 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
We have a reference cycle between LoginViewController and LoginView, created by referencing self in the closure. This causes a memory leak since LoginViewController/LoginView are never destroyed.
Attached file Pull request —
Attachment #8528577 - Flags: review?(sarentz)
Attachment #8528577 - Flags: review?(sarentz) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Group: mozilla-employee-confidential
Component: General → Firefox Accounts
Product: Firefox for Android → Firefox for iOS
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: