1105 - new_comment.cgi allows blank lines and extraineous spaces

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P2)

Description

[Jay Ball]

new_comment allows blank entries into the comment file. to forces something from
the user, try this patch: (it also strings ^$ spaces).

--- new_comment.cgi.ORIG Thu Oct 15 16:52:27 1998
+++ new_comment.cgi     Thu Oct 15 18:01:45 1998
@@ -28,11 +28,20 @@
     ($name, $value) = split(/=/, $pair);

     $value =~ tr/+/ /;
+    $value =~ s/^(\s*)//s;
+    $value =~ s/(\s*)$//s;
     $value =~ s/%([a-fA-F0-9][a-fA-F0-9])/pack("C", hex($1))/eg;
     $FORM{$name} = $value;
 }
-open(COMMENTS, ">>data/comments");
 $c=$FORM{"comment"};
+if ( (!defined $c) || ($c eq '') ) {
+    print "Content-type: text/html\n\n";
+    print "<TITLE>Nothing on your mind?</TITLE>";
+    print "<H1>Does you mind draw a blank?</H1>";
+    exit 0;
+}
+
+open(COMMENTS, ">>data/comments");
 print COMMENTS $FORM{"comment"} . "\n";
 close(COMMENTS);
 print "Content-type: text/html\n\n";

Comment 1

[Terry Weissman]

Reassigning to [e-mail], who now has front-line responsibility for
all Bonsai and Bugzilla bugs.

Comment 2

[Terry Weissman]

Reassigning back to me.  That stuff about me no longer being the front-line
person responsible for Bugzilla and Bonsai turned out to be short-lived.
Please pardon our confusion, and I'm very sorry about the spam.

Comment 3

[Terry Weissman]

Actually, I'd like to completely re-write all the quip stuff.

Comment 4

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 5

[Tara Hernandez]

okay, yeah, that's sorta annoying.

Comment 6

[Tara Hernandez]

Happy fun patch...

Comment 7

[Dave Miller [:justdave]]

per Terry, auto-verifying any resolved bug that hasn't been touched since before 
2.10 was released.

Comment 8

[Dave Miller [:justdave]]

Moving to Bugzilla product