1105027 - Element.createShadowTree does not update style sheets in the old ShadowRoot

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Cameron McCormack (:heycam)]

Attachment: test

Consider the attached test.  It should display "1 0 1", according to bug 1098270 comment 19.  I think we try to make the second number "0", by unbinding the contents of a ShadowRoot when we create a new, younger ShadowRoot for the host element, but we don't end up calling UpdateStyleSheet on <style> elements we unbind.

Comment 1

[Cameron McCormack (:heycam)]

In Element::CreateShadowRoot, we first set the newly ShadowRoot on the host element, and then we call UnbindFromTree on the children of the older ShadowRoot.  In HTMLStyleElement::UnbindFromTree, GetComposedDoc() returns null (because the <style> element now indeed isn't in the composed document) and we exit early without calling UpdateStyleSheetInternal.

I wonder if we can just remove that check and early exit in HTMLStyleElement::UnbindFromTree.

Comment 2

[Cameron McCormack (:heycam)]

(In reply to Cameron McCormack (:heycam) from comment #1)
> I wonder if we can just remove that check and early exit in
> HTMLStyleElement::UnbindFromTree.

This plus the changes mentioned in bug 1098270 to use GetComposedDoc() in nsStyleLinkElement::DoUpdateStyleSheet seems to work.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yes, the combination of those would make sense to me.  But again, it would be good to have a clear idea of what behavior the spec wants here....

Comment 4

[Cameron McCormack (:heycam)]

https://tbpl.mozilla.org/?tree=Try&rev=7f8fb00fc9c3 with those two changes.

Comment 5

[Cameron McCormack (:heycam)]

Raised https://github.com/w3c/web-platform-tests/issues/1415 for the failing WPT.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.