Closed
Bug 1105155
Opened 10 years ago
Closed 10 years ago
Indicate that an existing comment has been modified for tracking flags with prefill text
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: glob)
References
Details
Attachments
(1 file)
618 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
While editing bug 1104985, choosing the tracking flag changed my comment from [X] to [this should block because X]. Which makes me look bad and makes it less likely that [X] or the bug will be fixed.
Changing the meaning of my comment is NEVER OKAY. Please remove this misfeature (which was added in bug 853108).
Specifically, it silently added "[Tracking Requested - why for this release]:" to the top of my comment.
the comments are not "garbled" - the template text is prepended to existing contents.
i don't think that removing this feature is the correct course of action.
we should instead provide feedback to the user that their comment has been updated -- we can change the text of the "comment required" text to "comment updated" in this case.
Assignee: nobody → glob
Severity: major → normal
Component: General → Extensions: TrackingFlags
Summary: Comments are garbled when adding tracking flags → Indicate that an existing comment has been modified for tracking flags with prefill text
Attachment #8529086 -
Flags: review?(dkl)
Comment 3•10 years ago
|
||
Comment on attachment 8529086 [details] [diff] [review]
1105155_1.patch
Review of attachment 8529086 [details] [diff] [review]:
-----------------------------------------------------------------
Is good. r=dkl
Attachment #8529086 -
Flags: review?(dkl) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
9addfeb..1935ede master -> master
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Extensions: TrackingFlags → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•