1105190 - [BrowserAPI] Add supported EventHandler attributes to BrowserElement.webidl

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

For example

 attribute EventHandler onmozbrowsererror
 attribute EventHandler onmozbrewsertitlechange

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

Hi smaug, how do you think about this? I thought it would be nice to have all the public interface of mozbrowser in one place (BrowserElement.webidl). mozbrowser currently doesn't support DOM0 style event handlers.

If I'm going to fix this, what are needed other than add attributes to webidl? Do I need to touch EventNameList.h? Perhaps also nsGkAtomList.h.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

(onfoos aren't really DOM0, they are just EventHandlers. addEventListener adds EventListeners ;) )


So yes, you probably need to add stuff to nsGkAtomList, and thouch EventNameList too...
But I don't know currently the setup for BrowserElement.webidl, since I didn't review bug 1044736.
	

Do we want to support also onfoo DOM attributes? <iframe mozbrowser onmozbrowsererror=""> ?
If so, perhaps we want to support those onfoo webidl attributes and DOM attributes in all the elements in case <iframe mozbrowser> is enabled. And in that case just changing EventNameList.h, http://mxr.mozilla.org/mozilla-central/source/dom/webidl/EventHandler.webidl?rev=c112fdf29ed1#28 and nsGkAtomsList.h should be enough.

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.