1105367 - [Usage] Some strings aren't automatically translated on language switch

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Oleg Zasypkin [:azasypkin]]

Some strings (eg. data usage limit values (MB/GB) in FTE) aren't automatically translated when user changes language while app is open. 

It's quite minor, but still nice to have and easily achievable with data-l10n-* attributes.

Comment 1

[Salvador de la Puente González [:salva]]

I nominated this bug but, Oleg, can you provide confirmation that this is still happening?

Comment 2

[Oleg Zasypkin [:azasypkin]]

(In reply to Salvador de la Puente González [:salva] from comment #1)
> I nominated this bug but, Oleg, can you provide confirmation that this is
> still happening?

Yep, I still see it. You can check with the following STR:

* Open Cost Control app and go to the Data Alert FTE screen;
* Enable data alert and observe "When use is above"  input;
* Switch to Settings and change language to Arabic for example;
* Switch back to Cost Control app and observe input one more time;

The same is true for "Data usage limit" dialog itself. Though it's correctly re-translated if you tap on that input, that's why I considered it as a minor issue :)

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

qawanted to see if it's still reproducible on master.

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Shing, are you still on top of usage app?

Comment 5

[Shing Lyu [:shinglyu]]

Can't reproduce on the following build:
Gaia-Rev        e6a5e65ec98f3dee36c55809639c4800e52fbc19
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/dcb4c5573aef
Build-ID        20150119160230
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  40
FW-Date         Tue Oct 21 15:59:42 CST 2014
Bootloader      L1TC10011880

When I switched to Arabic language, the "1GB" text is translated to Arabic immediately.

Comment 6

[Oleg Zasypkin [:azasypkin]]

Hmm, strange I see "GB 1" instead of "‎جيجا بايت ‎1" right after language switch.

Comment 7

[Johan Lorenzo [:jlorenzo]]

I am able to reproduce on [1] if I follow the exact STR in comment 2. The main page is not affected.


[1]Gaia-Rev        e6a5e65ec98f3dee36c55809639c4800e52fbc19
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/dcb4c5573aef
Build-ID        20150119160230
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.jlorenzo.20141211.144125
FW-Date         Thu Dec 11 14:41:42 CET 2014
Bootloader      L1TC000118D0

Comment 8

[Noemí Freire (:noemi)]

Attachment: Bug1105367

(In reply to Oleg Zasypkin [:azasypkin] from comment #6)
> Hmm, strange I see "GB 1" instead of "‎جيجا بايت ‎1" right after language
> switch.
I also see that behavior. Environmental variables:
Flame 3.0 device
BuildId: 20150120065306
Gecko: 11fb7e0
Gaia: 174cc78
Platform: 38.0a1

Comment 9

[Brogan Zumwalt [Inactive]]

Confirming that I see comment 6 results in latest Flame 3.0 Nightly

Hmm, strange I see "GB 1" instead of "‎جيجا بايت ‎1" right after language switch.

Device: Flame 3.0 Master
BuildID: 20150120010227
Gaia: a5c5ac093814a80b0627514c3bd5f9e96c096a4b
Gecko: c1c6840d9255
Version: 38.0a1 (3.0 Master)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 10

[Shing Lyu [:shinglyu]]

I can reproduce it now after reboot. Same build as in comment 5.

Comment 11

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: blocking for it's non-translated string.

Comment 12

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva,
would you mind reviewing the patch?
Regards

Comment 13

[Salvador de la Puente González [:salva]]

Comment on attachment 8552353 [details] [review]
patch v1.0

Nice catch! Thank you!

Comment 14

[Marina Rodríguez [:mai]]

Master: dd90392f51884f86c55f8d8729fe65fd586c9189

Comment 15

[Marina Rodríguez [:mai]]

Comment on attachment 8552353 [details] [review]
patch v1.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature
[User impact] if declined: non-translated string
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low Risk
[String changes made]:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/fcfa62f7aa2297efeae7243f0fcbf8ba6dcea0ff

Comment 17

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Flame 3.0 and 2.2.

Following STR at comment 2, all strings are correctly translated.

Note: For 319MB Flame the previous app gets killed when switching between apps; I had to set the memory to 512MB in order to successfully do the STR.

Verified on:
Device: Flame 3.0
BuildID: 20150406010204
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: 4fe763cbe196
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Device: Flame 2.2
BuildID: 20150406002503
Gaia: a6351e1197d54f8624523c2db9ba1418f2aa046f
Gecko: c3335a5d3063
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0