1105432 - [pulsetranslator] Add back testing code which was removed by bug 1063791

Status: RESOLVED FIXED

(Webtools :: Pulse, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With bug 1063791 a couple of test messages were removed and the capability to simply push a single json message into the translator. That was very important for testing purposes, and I totally miss that now while working on bug 1105356.

Personally I'm not aware of that the format of build notifications have been changed. If there was an update in pulsetranslator, those messages should have been updated but not removed.

So I will check all those removed test messages for validity, and add back what is working.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So I tested all those test messages based on commit c9deae1490686ffbb0718ceab53fdd7458a8e21f, which is the parent of Mark's patch and I implemented for bug 1010120. All messages are working wonderful! No single one is failing.

Jonathan, mind giving me the feedback why those weren't working for you at all?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Add testing code back v1

This adds back all the code for testing local pulse notifications. If you want to test some of them run: runtranslator --display-only --push-message %path_to_message%.

One thing I did was to add another subfolder called firefox, so we can separate new example messages by application. Otherwise we would have to add firefox to all the message file names.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Need-info was not correctly set for jgriffin. Please see comment 1.

Comment 4

[Mark Côté [:mcote]]

Comment on attachment 8529220 [details] [diff] [review]
Add testing code back v1

Review of attachment 8529220 [details] [diff] [review]:
-----------------------------------------------------------------

I can't remember why I removed those test messages anymore... I suspect I was doing something wrong and thought they were broken.  Pretty sure jgriffin just went along with me. :)

r+ing since this just brings back old functionality, but please put in instructions on --push-message and --display-only into the README.md.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Add testing code back v2

Updated patch with the README additions.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Merged patch into master as:
https://github.com/mozilla/pulsetranslator/commit/939e7bb920547a3b42a7e1362da0b010d914c1e9