Right now we have in the Loop Mobile application Login screen a link to an old Terms of Service link that need to be replaced New ToS link: https://www.mozilla.org/about/legal/terms/firefox-hello/ Besides we need to add a Privacy Note that that should redirect to this link: https://www.mozilla.org/privacy/firefox-hello/ For more info, please see info in bug 1044411: https://bugzilla.mozilla.org/show_bug.cgi?id=1044411#c91
FTE + Log in (3/3) WF in http://j.mp/loopwfs shows the proposed links. Vicky, do we follow the WF to include the Privacy Note link as it's specified by Monica? or should we wait for a specific screen in case you want to do more changes in that screen? Thanks a lot!
For the time being, Vicky only has adapted the old v.1.1 green color to the new v.1.1.1 blue one. So, I believe you can simply add this new link to the text already implemented. Thanks.
Created attachment 8535049 [details] terms of service.jpeg
Attachment #8535049 - Flags: ui-review?(b.pmm)
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Created attachment 8535050 [details] [review] Github pull request thanks a lot for your time
Attachment #8535050 - Flags: review?(borja.bugzilla)
Comment on attachment 8535049 [details] terms of service.jpeg There's an underline missing in both "Terms of Service" and "Privacy Notice" texts.
Attachment #8535049 - Flags: ui-review?(b.pmm) → ui-review-
:) There weren't underlines in previous version, I gonna add this tomorrow, thanks a lot (In reply to Pau Masiá [:Pau] from comment #5) > Comment on attachment 8535049 [details] > terms of service.jpeg > > There's an underline missing in both "Terms of Service" and "Privacy Notice" > texts.
Created attachment 8535445 [details] Terms of Service with text-decoration underline Thanks a lot
Comment on attachment 8535050 [details] [review] Github pull request Forwarding r? to Jose Antonio
Attachment #8535050 - Flags: review?(borja.bugzilla) → review?(josea.olivera)
Comment on attachment 8535050 [details] [review] Github pull request LGTM. r=me Left a nit on the PR. Please address it and land at will. Thanks for taking care of it!
Attachment #8535050 - Flags: review?(josea.olivera) → review+
in master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/8162725f36ec4f9f5666deeaa8de4dc1a70f53ef
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.