Include in the Loop Mobile application the Privacy Note and the new ToS links

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: oteo, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Right now we have in the Loop Mobile application Login screen a link to an old Terms of Service link that need to be replaced
New ToS link: https://www.mozilla.org/about/legal/terms/firefox-hello/

Besides we need to add a Privacy Note that that should redirect to this link:  https://www.mozilla.org/privacy/firefox-hello/ 

For more info, please see info in bug 1044411: https://bugzilla.mozilla.org/show_bug.cgi?id=1044411#c91
(Reporter)

Comment 1

4 years ago
FTE + Log in (3/3) WF in http://j.mp/loopwfs shows the proposed links.

Vicky, do we follow the WF to include the Privacy Note link as it's specified by Monica? or should we wait for a specific screen in case you want to do more changes in that screen? Thanks a lot!
Flags: needinfo?(vpg)
(Reporter)

Updated

4 years ago
Blocks: 1097495
(Reporter)

Updated

4 years ago
Blocks: 1098491
(Reporter)

Updated

4 years ago
No longer blocks: 1097495
(Reporter)

Updated

4 years ago
Flags: needinfo?(b.pmm)

Comment 2

4 years ago
For the time being, Vicky only has adapted the old v.1.1 green color to the new v.1.1.1 blue one. So, I believe you can simply add this new link to the text already implemented. Thanks.
Flags: needinfo?(b.pmm)
(Assignee)

Comment 3

4 years ago
Created attachment 8535049 [details]
terms of service.jpeg
Attachment #8535049 - Flags: ui-review?(b.pmm)
(Assignee)

Updated

4 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
(Assignee)

Comment 4

4 years ago
Created attachment 8535050 [details] [review]
Github pull request

thanks a lot for your time
Attachment #8535050 - Flags: review?(borja.bugzilla)

Comment 5

4 years ago
Comment on attachment 8535049 [details]
terms of service.jpeg

There's an underline missing in both "Terms of Service" and "Privacy Notice" texts.
Attachment #8535049 - Flags: ui-review?(b.pmm) → ui-review-
(Assignee)

Comment 6

4 years ago
:) There weren't underlines in previous version, I gonna add this tomorrow, thanks a lot

(In reply to Pau Masiá [:Pau] from comment #5)
> Comment on attachment 8535049 [details]
> terms of service.jpeg
> 
> There's an underline missing in both "Terms of Service" and "Privacy Notice"
> texts.
(Assignee)

Comment 7

4 years ago
Created attachment 8535445 [details]
Terms of Service with text-decoration underline

Thanks a lot
Attachment #8535049 - Attachment is obsolete: true
Attachment #8535445 - Flags: ui-review?(b.pmm)

Updated

4 years ago
Attachment #8535445 - Flags: ui-review?(b.pmm) → ui-review+
Comment on attachment 8535050 [details] [review]
Github pull request

Forwarding r? to Jose Antonio
Attachment #8535050 - Flags: review?(borja.bugzilla) → review?(josea.olivera)
Comment on attachment 8535050 [details] [review]
Github pull request

LGTM. r=me

Left a nit on the PR. Please address it and land at will. Thanks for taking care of it!
Attachment #8535050 - Flags: review?(josea.olivera) → review+
(Assignee)

Comment 10

4 years ago
in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/8162725f36ec4f9f5666deeaa8de4dc1a70f53ef
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
Flags: needinfo?(vpg)
You need to log in before you can comment on or make changes to this bug.