1105499 - Include in the Loop Mobile application the Privacy Note and the new ToS links

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Right now we have in the Loop Mobile application Login screen a link to an old Terms of Service link that need to be replaced
New ToS link: https://www.mozilla.org/about/legal/terms/firefox-hello/

Besides we need to add a Privacy Note that that should redirect to this link:  https://www.mozilla.org/privacy/firefox-hello/ 

For more info, please see info in bug 1044411: https://bugzilla.mozilla.org/show_bug.cgi?id=1044411#c91

Comment 1

[Maria Angeles Oteo (:oteo)]

FTE + Log in (3/3) WF in http://j.mp/loopwfs shows the proposed links.

Vicky, do we follow the WF to include the Privacy Note link as it's specified by Monica? or should we wait for a specific screen in case you want to do more changes in that screen? Thanks a lot!

Comment 2

[Pau Masiá [:Pau]]

For the time being, Vicky only has adapted the old v.1.1 green color to the new v.1.1.1 blue one. So, I believe you can simply add this new link to the text already implemented. Thanks.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: terms of service.jpeg

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

thanks a lot for your time

Comment 5

[Pau Masiá [:Pau]]

Comment on attachment 8535049 [details]
terms of service.jpeg

There's an underline missing in both "Terms of Service" and "Privacy Notice" texts.

Comment 6

[Cristian Rodriguez (:crdlc)]

:) There weren't underlines in previous version, I gonna add this tomorrow, thanks a lot

(In reply to Pau Masiá [:Pau] from comment #5)
> Comment on attachment 8535049 [details]
> terms of service.jpeg
> 
> There's an underline missing in both "Terms of Service" and "Privacy Notice"
> texts.

Comment 7

[Cristian Rodriguez (:crdlc)]

Attachment: Terms of Service with text-decoration underline

Thanks a lot

Comment 8

[Borja Salguero [:borjasalguero]]

Comment on attachment 8535050 [details] [review]
Github pull request

Forwarding r? to Jose Antonio

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8535050 [details] [review]
Github pull request

LGTM. r=me

Left a nit on the PR. Please address it and land at will. Thanks for taking care of it!

Comment 10

[Cristian Rodriguez (:crdlc)]

in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/8162725f36ec4f9f5666deeaa8de4dc1a70f53ef