Closed Bug 1105518 Opened 5 years ago Closed 2 years ago
Stop redefining non-configurable properties in sandbox code
See bug 1101123 comment 3. The most plausible solution for this is probably to make the sandbox global involved a proxy, fixing whatever issues block proxies as globals... Or is there a different long-term plan for this stuff? Bill?
Once this is fixed, JSPROP_REDEFINE_NONCONFIGURABLE needs to go away.
I guess allowing proxy globals is the long term plan, yes.
bug 1445551 removed the sandbox code which used JSPROP_REDEFINE_NONCONFIGURABLE, so the skip-redefine-check hack in js::NativeDefineProperty can now be removed, too. \o/ https://searchfox.org/mozilla-central/search?q=JSPROP_REDEFINE_NONCONFIGURABLE&case=true&path=
Priority: -- → P3
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8975456 - Flags: review?(jorendorff)
Attachment #8975456 - Flags: review?(jorendorff) → review+
Rebased to apply cleanly on inbound, carrying r+.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1d498636e0d5 Remove JSPROP_REDEFINE_NONCONFIGURABLE from jsapi. r=jorendorff
You need to log in before you can comment on or make changes to this bug.