1105518 - Stop redefining non-configurable properties in sandbox code

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 1101123 comment 3.

The most plausible solution for this is probably to make the sandbox global involved a proxy, fixing whatever issues block proxies as globals...

Or is there a different long-term plan for this stuff?  Bill?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Once this is fixed, JSPROP_REDEFINE_NONCONFIGURABLE needs to go away.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I guess allowing proxy globals is the long term plan, yes.

Comment 3

[André Bargull [:anba]]

bug 1445551 removed the sandbox code which used JSPROP_REDEFINE_NONCONFIGURABLE, so the skip-redefine-check hack in js::NativeDefineProperty can now be removed, too. \o/

https://searchfox.org/mozilla-central/search?q=JSPROP_REDEFINE_NONCONFIGURABLE&case=true&path=

Comment 4

[André Bargull [:anba]]

Attachment: bug1105518.patch

Comment 5

[André Bargull [:anba]]

Attachment: bug1105518.patch

Rebased to apply cleanly on inbound, carrying r+.

Comment 6

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=75c55845c8e80993c58cc38106a720a57bbcf3b6

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d498636e0d5
Remove JSPROP_REDEFINE_NONCONFIGURABLE from jsapi. r=jorendorff

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1d498636e0d5