Closed Bug 1105518 Opened 5 years ago Closed 2 years ago

Stop redefining non-configurable properties in sandbox code

Categories

(Core :: XPConnect, defect, P3)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bzbarsky, Assigned: anba)

Details

Attachments

(1 file, 1 obsolete file)

See bug 1101123 comment 3.

The most plausible solution for this is probably to make the sandbox global involved a proxy, fixing whatever issues block proxies as globals...

Or is there a different long-term plan for this stuff?  Bill?
Flags: needinfo?(wmccloskey)
Once this is fixed, JSPROP_REDEFINE_NONCONFIGURABLE needs to go away.
I guess allowing proxy globals is the long term plan, yes.
Flags: needinfo?(wmccloskey)
bug 1445551 removed the sandbox code which used JSPROP_REDEFINE_NONCONFIGURABLE, so the skip-redefine-check hack in js::NativeDefineProperty can now be removed, too. \o/

https://searchfox.org/mozilla-central/search?q=JSPROP_REDEFINE_NONCONFIGURABLE&case=true&path=
Priority: -- → P3
Attached patch bug1105518.patch (obsolete) — Splinter Review
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8975456 - Flags: review?(jorendorff)
Attachment #8975456 - Flags: review?(jorendorff) → review+
Attached patch bug1105518.patchSplinter Review
Rebased to apply cleanly on inbound, carrying r+.
Attachment #8975456 - Attachment is obsolete: true
Attachment #8985792 - Flags: review+
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d498636e0d5
Remove JSPROP_REDEFINE_NONCONFIGURABLE from jsapi. r=jorendorff
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1d498636e0d5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.