Closed
Bug 1105563
Opened 10 years ago
Closed 9 years ago
Move Themed* to sub-package
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file, 1 obsolete file)
Now that the build process is easier to fix.
I'm thinking:
.../base/widget/themed/
Assignee | ||
Comment 1•10 years ago
|
||
Note that this patch includes the patches from bug 1085771.
My new package does not exist when I build on this patch:
/home/mcomella/dev/moz/mobile/android/base/CustomEditText.java:8: error: package org.mozilla.gecko.widget.themed does not exist
Any ideas, Nick?
Attachment #8529381 -
Flags: feedback?(nalexander)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #1)
> Created attachment 8529381 [details] [diff] [review]
> Move Themed* to ../widget/themed/
>
> Note that this patch includes the patches from bug 1085771.
>
> My new package does not exist when I build on this patch:
>
> /home/mcomella/dev/moz/mobile/android/base/CustomEditText.java:8: error:
> package org.mozilla.gecko.widget.themed does not exist
>
> Any ideas, Nick?
Yeah, you'll want to update move widget/generate*py to widget/themed/generate*py, then move the Theme* files to widget/themed, and then verify that running the script (use |mach python mobile/android/widget/themed/generated*py|) doesn't change the sources. Do this as a pre to your substantive LWT changes, perhaps?
Comment 3•10 years ago
|
||
Comment on attachment 8529381 [details] [diff] [review]
Move Themed* to ../widget/themed/
Review of attachment 8529381 [details] [diff] [review]:
-----------------------------------------------------------------
I commented in the ticket. Flag me when you're ready for another pass.
Attachment #8529381 -
Flags: feedback?(nalexander)
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1105563 - Move Themed* to widget.themed package. r=nalexander
Attachment #8653095 -
Flags: review?(nalexander)
Assignee | ||
Updated•9 years ago
|
Attachment #8529381 -
Attachment is obsolete: true
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #2)
> Yeah, you'll want to update move widget/generate*py to
> widget/themed/generate*py, then move the Theme* files to widget/themed, and
> then verify that running the script (use |mach python
> mobile/android/widget/themed/generated*py|) doesn't change the sources. Do
> this as a pre to your substantive LWT changes, perhaps?
Did this. Note that this patch is largely done by IJ.
Updated•9 years ago
|
Attachment #8653095 -
Flags: review?(nalexander) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8653095 [details]
MozReview Request: Bug 1105563 - Move Themed* to widget.themed package. r=nalexander
https://reviewboard.mozilla.org/r/17365/#review15459
This looks fine, but I'm not sure I trust the IDE to get everything (especially generated/preprocessed code). There isn't much, but a green try build is well worth the time.
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/f4b8d637f2d71dc83d3b7f906292641675b07732
changeset: f4b8d637f2d71dc83d3b7f906292641675b07732
user: Michael Comella <michael.l.comella@gmail.com>
date: Wed Aug 26 14:28:05 2015 -0700
description:
Bug 1105563 - Move Themed* to widget.themed package. r=nalexander
Comment 9•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•