1105563 - Move Themed* to sub-package

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Now that the build process is easier to fix.

I'm thinking:

.../base/widget/themed/

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Move Themed* to ../widget/themed/

Note that this patch includes the patches from bug 1085771.

My new package does not exist when I build on this patch:

/home/mcomella/dev/moz/mobile/android/base/CustomEditText.java:8: error: package org.mozilla.gecko.widget.themed does not exist

Any ideas, Nick?

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #1)
> Created attachment 8529381 [details] [diff] [review]
> Move Themed* to ../widget/themed/
> 
> Note that this patch includes the patches from bug 1085771.
> 
> My new package does not exist when I build on this patch:
> 
> /home/mcomella/dev/moz/mobile/android/base/CustomEditText.java:8: error:
> package org.mozilla.gecko.widget.themed does not exist
> 
> Any ideas, Nick?

Yeah, you'll want to update move widget/generate*py to widget/themed/generate*py, then move the Theme* files to widget/themed, and then verify that running the script (use |mach python mobile/android/widget/themed/generated*py|) doesn't change the sources.  Do this as a pre to your substantive LWT changes, perhaps?

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8529381 [details] [diff] [review]
Move Themed* to ../widget/themed/

Review of attachment 8529381 [details] [diff] [review]:
-----------------------------------------------------------------

I commented in the ticket.  Flag me when you're ready for another pass.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: MozReview Request: Bug 1105563 - Move Themed* to widget.themed package. r=nalexander

Bug 1105563 - Move Themed* to widget.themed package. r=nalexander

Comment 5

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

(In reply to Nick Alexander :nalexander from comment #2)
> Yeah, you'll want to update move widget/generate*py to
> widget/themed/generate*py, then move the Theme* files to widget/themed, and
> then verify that running the script (use |mach python
> mobile/android/widget/themed/generated*py|) doesn't change the sources.  Do
> this as a pre to your substantive LWT changes, perhaps?

Did this. Note that this patch is largely done by IJ.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8653095 [details]
MozReview Request: Bug 1105563 - Move Themed* to widget.themed package. r=nalexander

https://reviewboard.mozilla.org/r/17365/#review15459

This looks fine, but I'm not sure I trust the IDE to get everything (especially generated/preprocessed code).  There isn't much, but a green try build is well worth the time.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9d218e6f22f

Comment 8

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/f4b8d637f2d71dc83d3b7f906292641675b07732
changeset:  f4b8d637f2d71dc83d3b7f906292641675b07732
user:       Michael Comella <[e-mail]>
date:       Wed Aug 26 14:28:05 2015 -0700
description:
Bug 1105563 - Move Themed* to widget.themed package. r=nalexander

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f4b8d637f2d7