1105585 - Fix bug bounty form to validate its input more and relax the restriction on the paid field to include -+? suffix

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

+++ This bug was initially created as a clone of Bug #1103837 +++

Currently, the bug county form allows the paid field to include any characters, but the parser that populates the "edit" form does not support anything other than numbers. It turns out the use-case of the paid field requires a -/+/? after the paid field. (This was originally going to be a separate field, as I recall.)
For a simple fix, we'll fix the parser to match the user expectation, although really it would've made more sense to record the +/? state in the form encounter from the start.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1105585-v1.patch

Improve form validation, and at the same time add an optional suffix to the paid field.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1105585-v1.1.patch

Oops. This one is without console.log statements.

Comment 3

[:glob ✱]

Comment on attachment 8529491 [details] [diff] [review]
bug-1105585-v1.1.patch

Review of attachment 8529491 [details] [diff] [review]:
-----------------------------------------------------------------

the 'amount paid' field is optional, however if left blank an "invalid value" error is displayed.
r=glob with this fixed on commit

::: extensions/BMO/Extension.pm
@@ +279,3 @@
>          (?<reported_date>  $date)   ?  \s*,\s*
>          (?<fixed_date>     $date)   ?  \s*,\s*
>          (?<awarded_date>   $date)   ?  \s*,\s*

nit: realign things, it looked so pretty before

Comment 4

[Raymond Forbes[:rforbes]]

hello,

what is the status of this?

thanks!

Comment 5

[:glob ✱]

sorry this was missed; i've committed the patch however it won't be active on bmo until the next production push (currently scheduled for this week).

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   0cd42fd..9addfeb  master -> master

Comment 6

[:glob ✱]

this is now live on production.