1105608 - PNK_EXPORT_FROM is not handled in frontend::EmitTree.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:

1. Run debug build js shell
2. enter following code
  eval("export { x } from 'a';");


Expected result:

"SyntaxError: modules are not implemented yet" is thrown.


Actual result:

Assertion fails at frontend::EmitTree.
>    switch (pn->getKind()) {
>...
>      default:
>        MOZ_ASSERT(0);
>    }

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Throw SyntaxError for export-from.

bug1105608.js does not check the thrown exception's type,
because the code should throw a different error than SyntaxError after modules are implemented,
and the error's type is not yet specified in the spec (or I overlooked it?).

Green on try runs:
  https://tbpl.mozilla.org/?tree=Try&rev=470ce7a92717 (only BytecodeEmitter.cpp change)
  https://tbpl.mozilla.org/?tree=Try&rev=7c49fc8cf171 (added a test)

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 8529782 [details] [diff] [review]
Throw SyntaxError for export-from.

Review of attachment 8529782 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 4

[Tooru Fujisawa [:arai]]

Thank you for reviewing :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/a65478d63b75

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a65478d63b75