1105739 - "loop is not enabled" error at browser startup and at new page opening

Status: RESOLVED INCOMPLETE

(Firefox :: Toolbars and Customization, defect)

Description

[Cornel Ionce [:noni]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141125180439

When the browser starts or when opening a new window I got the following error in the console: https://pastebin.mozilla.org/7585607

Not reproducing in Firefox 33.1.1, build ID: 20141113143407.

Comment 1

[u279076]

Is this on a new profile with 34 or are you swapping between 33.1.1 and 34 on the same profile?

Comment 2

[Toady]

If preference "loop.enabled" is set to false (Many users might not use this feature and disable it) then
MozLoopService.jsm throws an error to console on a promise chain rejection.

Also when "loop.enabled" is set to false this message is logged to console "[CustomizableUI]" "Custom widget with id loop-button-throttled does not return a valid node" CustomizableUI.jsm:168

In Firefox 34.0.5 (Release)
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Sat Jan 17 2015 14:46:19 GMT+1000
Full Message: loop is not enabled


In Firefox 35.0 (Release)
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Sat Jan 17 2015 14:53:17 GMT+1000
Full Message: Error: loop is not enabled

In Firefox 36.0b1
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Sat Jan 17 2015 14:47:04 GMT+1000
Full Message: Error: loop is not enabled
Full Stack: this.MozLoopService.initialize<@resource:///modules/loop/MozLoopService.jsm:1085:29
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
LoopUI.init@chrome://browser/content/browser.js:2336:7
gBrowserInit._delayedStartup@chrome://browser/content/browser.js:10679:5

In Firefox 37.0a1
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Sat Jan 17 2015 14:50:31 GMT+1000
Full Message: Error: loop is not enabled
Full Stack: this.MozLoopService.initialize<@resource:///modules/loop/MozLoopService.jsm:1085:29
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
LoopUI.init@chrome://browser/content/browser.js:4136:7
gBrowserInit._delayedStartup@chrome://browser/content/browser.js:10794:5

In Firefox 38.0a1
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Sat Jan 17 2015 14:51:27 GMT+1000
Full Message: Error: loop is not enabled
Full Stack: this.MozLoopService.initialize<@resource:///modules/loop/MozLoopService.jsm:1078:29
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
LoopUI.init@chrome://browser/content/browser.js:4136:7
gBrowserInit._delayedStartup@chrome://browser/content/browser.js:10794:5

Comment 3

[Adam Moore]

This is extremely noisy for what should be a silent process, and it happens every session, every new window.  The fact that the service is turned off by the user should not produce an error.  It works this way because of this bit in MozLoopService.jsm:

    // Don't do anything if loop is not enabled.
    if (!Services.prefs.getBoolPref("loop.enabled")) {
      return Promise.reject(new Error("loop is not enabled"));
    }

If this is how you want to handle the promise, then the caller should be handling the rejection.

Comment 4

[Mark Banner (:standard8)]

Some of this improved a while ago, the only issue with loop.enabled now is:

[CustomizableUI] Custom widget with id loop-button does not return a valid node

I think this is an issue with how the buttons are handled, so moving this to the better component for it.

Comment 5

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.