1105797 - Unhandled IRC message 501: unknown mode char

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

STR: "/mode +t" in a channel.

WARN. (@ prpl-irc: ircSocket.prototype.onDataReceived resource://gre/components/irc.js:688) 
Unhandled IRC message: 
:fripp.mozilla.org 501 aleth t :is unknown mode char to me

Comment 1

[Mrinal Dhar]

Attachment: Handles the error code by logging relevant message in the server tab

Comment 2

[aleth [:aleth]]

Comment on attachment 8727623 [details] [diff] [review]
Handles the error code by logging relevant message in the server tab

Review of attachment 8727623 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/locales/en-US/irc.properties
@@ +171,5 @@
>  error.sendMessageFailed=An error occurred while sending your last message. Please try again once the connection has been reestablished.
>  #    %1$S is the channel the user tried to join, %2$S is the channel
>  #    he was forwarded to.
>  error.channelForward=You may not join %1$S, and were automatically redirected to %2$S.
> +error.unknownMode=Unknown value for mode.

How hard would it be to include the mode char in the error message?
"'t' is not a valid user mode on this server."

Comment 3

[Mrinal Dhar]

Attachment: Also includes the user mode in the error message

This should do it.

Comment 4

[aleth [:aleth]]

(In reply to Mrinal Dhar from comment #3)
> Created attachment 8727801 [details] [diff] [review]
> Also includes the user mode in the error message
> 
> This should do it.

How?

Comment 5

[Patrick Cloke [:clokep]]

(In reply to aleth [:aleth] from comment #4)
> (In reply to Mrinal Dhar from comment #3)
> > Created attachment 8727801 [details] [diff] [review]
> > Also includes the user mode in the error message
> > 
> > This should do it.
> 
> How?

I think what aleth is trying to say is that you've added a formatting character (%s) to the format string, but you don't pass in the invalid mode at all to replace that character

Comment 6

[Mrinal Dhar]

Attachment: Includes the invalid mode in the error message

Ah, forgot to run hg qref, my bad. Here's the new patch.

Comment 7

[aleth [:aleth]]

Comment on attachment 8727837 [details] [diff] [review]
Includes the invalid mode in the error message

Review of attachment 8727837 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: chat/locales/en-US/irc.properties
@@ +171,5 @@
>  error.sendMessageFailed=An error occurred while sending your last message. Please try again once the connection has been reestablished.
>  #    %1$S is the channel the user tried to join, %2$S is the channel
>  #    he was forwarded to.
>  error.channelForward=You may not join %1$S, and were automatically redirected to %2$S.
> +error.unknownMode='%S' is not a valid user mode on this server.

Please add a localization note comment so the localisers understand what %S is for.

Comment 8

[Mrinal Dhar]

Attachment: Handles error code 501

Added Localization note as comment.

Comment 9

[aleth [:aleth]]

Comment on attachment 8728072 [details] [diff] [review]
Handles error code 501

Review of attachment 8728072 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this!

Comment 10

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/4eae6164ce3d82a465431a339df9685481c88ce4
Bug 1105797 - Handle IRC message 501. r=aleth

Comment 11

[aleth [:aleth]]

Comment on attachment 8728072 [details] [diff] [review]
Handles error code 501

Review of attachment 8728072 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/irc/ircBase.jsm
@@ +1431,5 @@
>        return false;
>      },
>      "501": function(aMessage) { // ERR_UMODEUNKNOWNFLAGS
>        // :Unknown MODE flag
> +      return serverErrorMessage(this, aMessage, _("error.unknownMode", aMessage.params[1]));

Nit: Please try not to exceed the 80 char limit in the future whenever possible.

Fixed on checkin.