Closed
Bug 1105797
Opened 8 years ago
Closed 6 years ago
Unhandled IRC message 501: unknown mode char
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 48
People
(Reporter: aleth, Assigned: mrinal.dhar, Mentored)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 3 obsolete files)
2.32 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
STR: "/mode +t" in a channel. WARN. (@ prpl-irc: ircSocket.prototype.onDataReceived resource://gre/components/irc.js:688) Unhandled IRC message: :fripp.mozilla.org 501 aleth t :is unknown mode char to me
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mrinal.dhar
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8727623 -
Flags: review?(aleth)
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 8727623 [details] [diff] [review] Handles the error code by logging relevant message in the server tab Review of attachment 8727623 [details] [diff] [review]: ----------------------------------------------------------------- ::: chat/locales/en-US/irc.properties @@ +171,5 @@ > error.sendMessageFailed=An error occurred while sending your last message. Please try again once the connection has been reestablished. > # %1$S is the channel the user tried to join, %2$S is the channel > # he was forwarded to. > error.channelForward=You may not join %1$S, and were automatically redirected to %2$S. > +error.unknownMode=Unknown value for mode. How hard would it be to include the mode char in the error message? "'t' is not a valid user mode on this server."
Assignee | ||
Comment 3•6 years ago
|
||
This should do it.
Attachment #8727623 -
Attachment is obsolete: true
Attachment #8727623 -
Flags: review?(aleth)
Reporter | ||
Comment 4•6 years ago
|
||
(In reply to Mrinal Dhar from comment #3) > Created attachment 8727801 [details] [diff] [review] > Also includes the user mode in the error message > > This should do it. How?
Comment 5•6 years ago
|
||
(In reply to aleth [:aleth] from comment #4) > (In reply to Mrinal Dhar from comment #3) > > Created attachment 8727801 [details] [diff] [review] > > Also includes the user mode in the error message > > > > This should do it. > > How? I think what aleth is trying to say is that you've added a formatting character (%s) to the format string, but you don't pass in the invalid mode at all to replace that character
Updated•6 years ago
|
Attachment #8727801 -
Flags: feedback+
Assignee | ||
Comment 6•6 years ago
|
||
Ah, forgot to run hg qref, my bad. Here's the new patch.
Attachment #8727801 -
Attachment is obsolete: true
Attachment #8727837 -
Flags: review?
Reporter | ||
Comment 7•6 years ago
|
||
Comment on attachment 8727837 [details] [diff] [review] Includes the invalid mode in the error message Review of attachment 8727837 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. ::: chat/locales/en-US/irc.properties @@ +171,5 @@ > error.sendMessageFailed=An error occurred while sending your last message. Please try again once the connection has been reestablished. > # %1$S is the channel the user tried to join, %2$S is the channel > # he was forwarded to. > error.channelForward=You may not join %1$S, and were automatically redirected to %2$S. > +error.unknownMode='%S' is not a valid user mode on this server. Please add a localization note comment so the localisers understand what %S is for.
Attachment #8727837 -
Flags: review? → review-
Assignee | ||
Comment 8•6 years ago
|
||
Added Localization note as comment.
Attachment #8727837 -
Attachment is obsolete: true
Reporter | ||
Comment 9•6 years ago
|
||
Comment on attachment 8728072 [details] [diff] [review] Handles error code 501 Review of attachment 8728072 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for taking care of this!
Attachment #8728072 -
Flags: review+
Reporter | ||
Updated•6 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 10•6 years ago
|
||
https://hg.mozilla.org/comm-central/rev/4eae6164ce3d82a465431a339df9685481c88ce4 Bug 1105797 - Handle IRC message 501. r=aleth
Reporter | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48
Reporter | ||
Comment 11•6 years ago
|
||
Comment on attachment 8728072 [details] [diff] [review] Handles error code 501 Review of attachment 8728072 [details] [diff] [review]: ----------------------------------------------------------------- ::: chat/protocols/irc/ircBase.jsm @@ +1431,5 @@ > return false; > }, > "501": function(aMessage) { // ERR_UMODEUNKNOWNFLAGS > // :Unknown MODE flag > + return serverErrorMessage(this, aMessage, _("error.unknownMode", aMessage.params[1])); Nit: Please try not to exceed the 80 char limit in the future whenever possible. Fixed on checkin.
You need to log in
before you can comment on or make changes to this bug.
Description
•