46 bytes, text/x-github-pull-request
|Details | Review|
When an user moves an application around in edit mode, there needs to be a visual indication that the intended move is valid. Please refer to section 5.6 in the specification found here for more info: https://bugzilla.mozilla.org/attachment.cgi?id=8529891
Implemented, but need to write tests. https://github.com/Cwiiis/gaia/tree/bug1105850-highlight-hovered-group
Status: NEW → ASSIGNED
Implement the feature and add a marionette test for it.
Comment on attachment 8533739 [details] [review] Highlight the group being hovered over in edit mode LGTM, thanks a lot
Attachment #8533739 - Flags: review?(crdlc) → review+
Comment on attachment 8533739 [details] [review] Highlight the group being hovered over in edit mode I think crdlc's review is enough, but feel free to have a look and disagree if you get the time :)
Tests aren't triggering, but I don't believe this will break things (apologies if it does). Merged: https://github.com/mozilla-b2g/gaia/commit/abbb8a8e56db81489f5d5dc3722c9cfe7773726c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Verified fixed on the latest Nightly Flame 3.0 build Results: Dragging around an app icon in edit mode causes visual effects indicating valid moves Device: Flame 3.0 (KK - Nightly - Full Flash) Build ID: 20150209010211 Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec Gecko: 3436787a82d0 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
You need to log in before you can comment on or make changes to this bug.