1105850 - (App-Grouping) Add visual cue for app placement.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Hung Nguyen]

When an user moves an application around in edit mode, there needs to be a visual indication that the intended move is valid. 

Please refer to section 5.6 in the specification found here for more info: 
https://bugzilla.mozilla.org/attachment.cgi?id=8529891

Comment 1

[Chris Lord [:cwiiis]]

Implemented, but need to write tests.

https://github.com/Cwiiis/gaia/tree/bug1105850-highlight-hovered-group

Comment 2

[Chris Lord [:cwiiis]]

Attachment: Highlight the group being hovered over in edit mode

Implement the feature and add a marionette test for it.

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8533739 [details] [review]
Highlight the group being hovered over in edit mode

LGTM, thanks a lot

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8533739 [details] [review]
Highlight the group being hovered over in edit mode

I think crdlc's review is enough, but feel free to have a look and disagree if you get the time :)

Comment 5

[Chris Lord [:cwiiis]]

Tests aren't triggering, but I don't believe this will break things (apologies if it does).

Merged: https://github.com/mozilla-b2g/gaia/commit/abbb8a8e56db81489f5d5dc3722c9cfe7773726c

Comment 6

[Joshua Mitchell (Inactive)]

Verified fixed on the latest Nightly Flame 3.0 build

Results: Dragging around an app icon in edit mode causes visual effects indicating valid moves

Device: Flame 3.0 (KK - Nightly - Full Flash)
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0