1105986 - [Stingray][Home] Delete card

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Under edit mode, user can press the delete button appeared on the item to delete a card.

Comment 2

[howie [:howie]]

Hi Rex, I'll assign this to you now. Feel free to let me know if you want to reassign, thanks.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

This version implements rename button and delete button as UI together.
(but only delete button works now. Rename button will be implemented in another bug)

I'm not very satisfied on solution of spatial navigating; Currently we need to add/remove buttons with spatialNavigator each time arrow key is pressed, so several works on this should be taken.
But I haven't come up with better idea yet.

Tzu-lin would you help review this bug?

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8544517 [details] [review]
patch

Thanks for the patch. I am OK with the structure overall. 
But we forgot to do one thing here: Decks cannot be deleted. I think we should implement that here too.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8544517 [details] [review]
patch

Hunter said that rename shouldn't be visible for deck either, so here's the new patch.

Tzu-lin may you take a look again? What I changed is in the second commit.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8544517 [details] [review]
patch

Looks good to me, thanks

Comment 7

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thank you Tzu-lin!

Sorry for the unsuccessful trying to use autolander above :-/ I'd land it once tests are ok.

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master
https://github.com/mozilla-b2g/gaia/commit/970e08f3ac299b9e90d117373b0b8ff51ff446d3