1106059 - Can't save new page

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Sebastian Zartner [:sebo]]

Attachment: Post parameters.txt

I'm getting an 'Internal Server Error' (HTTP status code 500) when I try to save a new page I wanted to create for the 'object-fit' CSS property. Editing other pages today worked fine.

First I thought this was because I cloned an existing page, though it also happens when creating a completely new page.

I attached the POST parameters of the saving action.

Sebastian

Comment 1

[Māris Fogels [:mars] (please needinfo)]

Moving to sev:major to stop the bug pager.

Comment 2

[Jean-Yves Perrier [:teoli]]

I confirm the bug.

Note that, for legal reasons (copyright violation), I deleted that very same page earlier this week (using the admin interface).

This bug is really severe: object-fit must be documented very soon and get a lot of attention.

Comment 3

[James Bennett [:ubernostrum]]

The problem is that doing it in the admin (this is a bug) deleted it without leaving the normal deletion log, so the code that checks for deleted documents at the same URL did not find that there was one (since it checks by querying the deletion log).

We should probably disable the admin delete button, and force all deletion to go through the interface that logs deletions.

In the meantime, anyone with admin access can purge the deleted document, and things will be fine.

Comment 4

[Jean-Yves Perrier [:teoli]]

Thanks to James and Jezdez who came back from PTO to help on this.

I was sure the "delete" button was the only interface and that it was a "purge".

I've followed the other procedure and it should be ok. I'm closing it for now. Reopen if needed.

Ubernostrum: ok for removing the delete button from the admin panel, our requirement is to have a purge feature. The other way of doing it, unknown to me, is perfectly fine. (sorry for the misunderstanding)

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to Jean-Yves Perrier [:teoli] from comment #2)
> Note that, for legal reasons (copyright violation), I deleted that very same
> page earlier this week (using the admin interface).

Sorry, how can the documentation of a CSS property cause a copyright violation? Was it just copied over from another page?

Sebastian

Comment 6

[Jean-Yves Perrier [:teoli]]

Yes, it was a copy paste from another page, with a different incompatible license.

Comment 7

[Sebastian Zartner [:sebo]]

(In reply to Jean-Yves Perrier [:teoli] from comment #6)
> Yes, it was a copy paste from another page, with a different incompatible
> license.

I see. Well, now it's self-made by me. :-)

Sebastian

Comment 8

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/73c835e61e4f6e180d82d577cc48c3b2aebc40e9
Bug 1106059: Disable admin Document deletion.

We already have the delete-from-object-list action disabled; this
simply completes that process by disabling the delete button on
individual Documents, by hard-wiring a lack of delete permission for
every user.

As a result, all Document deletion will be forced through the custom
kuma deletion infrastructure, which ensures we have an auditable trail
of who has deleted a Document and why.

https://github.com/mozilla/kuma/commit/9493ae7331bba0b92b467bb4c91a33672c8d4e0e
Merge pull request #2931 from ubernostrum/remove-admin-delete-1106059

Bug 1106059: Disable admin Document deletion.